NOTE that downloads from git don't use baseTLSConfig

mtrmac · mtrmac · commit 929d193dee06 · 2026-02-17T23:49:47.000+01:00
Should not change behavior.

Signed-off-by: Miloslav Trmač &lt;mitr@redhat.com&gt;
diff --git a/pkg/download/download.go b/pkg/download/download.go
@@ -135,7 +135,7 @@ func cloneToDirectory(url, dir string) ([]byte, string, error) {
 	}
 
 	logrus.Debugf("fetching repo %q and branch (or commit ID) %q to %q", gitRepo, gitRef, dir)
-	args := []string{"fetch", "-u", "--depth=1", "origin", "--", gitRef}
+	args := []string{"fetch", "-u", "--depth=1", "origin", "--", gitRef} // NOTE: this does not respect baseTLSConfig.
 	cmd = exec.Command("git", args...)
 	cmd.Dir = dir
 	combinedOutput, err = cmd.CombinedOutput()

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ func cloneToDirectory(url, dir string) ([]byte, string, error) {`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`logrus.Debugf("fetching repo %q and branch (or commit ID) %q to %q", gitRepo, gitRef, dir)`
`138`		`- args := []string{"fetch", "-u", "--depth=1", "origin", "--", gitRef}`
	`138`	`+ args := []string{"fetch", "-u", "--depth=1", "origin", "--", gitRef} // NOTE: this does not respect baseTLSConfig.`
`139`	`139`	`cmd = exec.Command("git", args...)`
`140`	`140`	`cmd.Dir = dir`
`141`	`141`	`combinedOutput, err = cmd.CombinedOutput()`