Merge pull request #190 from Luap99/lint

Gh action and golangci-lint updates

Author: vrothberg

.github/workflows/validate.yml

@@ -8,27 +8,29 @@ on:
       - release-*
   pull_request:
 
-jobs:
+env:
+  LINT_VERSION: v2.6.1
 
+jobs:
   lint:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
       with:
         fetch-depth: 2
-    - uses: actions/setup-go@v5
+    - uses: actions/setup-go@v6
     - name: lint
-      uses: golangci/golangci-lint-action@v4
+      uses: golangci/golangci-lint-action@v8
       with:
         version: "${{ env.LINT_VERSION }}"
         args: --verbose
 
   codespell:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: install deps
       # Version of codespell bundled with Ubuntu is way old, so use pip.
-      run: pip install codespell
+      run: pip install --break-system-packages codespell
     - name: run codespell
       run: codespell --dictionary=-

.golangci.yml

@@ -1,6 +1,12 @@
-# For documentation, see https://golangci-lint.run/usage/configuration/
-
+version: "2"
 linters:
   enable:
     - errorlint
+formatters:
+  enable:
     - gofumpt
+
+# Show all issues at once so it is visible how much must be fixed
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0

internal/dev/tty.go

@@ -73,7 +73,7 @@ func TTYs() (*[]TTY, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer devDir.Close()
+	defer devDir.Close() //nolint:errcheck
 
 	devices := []string{}
 	devTTYs, err := devDir.Readdirnames(0)
@@ -91,7 +91,7 @@ func TTYs() (*[]TTY, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer devPTSDir.Close()
+	defer devPTSDir.Close() //nolint:errcheck
 
 	devPTSs, err := devPTSDir.Readdirnames(0)
 	if err != nil {

internal/host/host_nocgo.go

@@ -1,5 +1,4 @@
 //go:build !cgo
-// +build !cgo
 
 // Copyright 2018 psgo authors
 //

internal/proc/ns.go

@@ -47,7 +47,7 @@ func ReadMappings(path string) ([]idtools.IDMap, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer file.Close()
+	defer file.Close() //nolint:errcheck
 
 	var mappings []idtools.IDMap
 

internal/proc/pids.go

@@ -31,7 +31,7 @@ func GetPIDs() ([]string, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer procDir.Close()
+	defer procDir.Close() //nolint:errcheck
 
 	// extract string slice of all directories in procDir
 	pidDirs, err := procDir.Readdirnames(0)
@@ -74,7 +74,7 @@ func getPIDsFromCgroupV1(pid string) ([]string, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer f.Close()
+	defer f.Close() //nolint:errcheck
 
 	scanner := bufio.NewScanner(f)
 	cgroupPath := ""
@@ -109,7 +109,7 @@ func getPIDsFromCgroupV1(pid string) ([]string, error) {
 			return nil, err
 		}
 	}
-	defer f.Close()
+	defer f.Close() //nolint:errcheck
 
 	pids := []string{}
 	scanner = bufio.NewScanner(f)
@@ -128,7 +128,7 @@ func getPIDsFromCgroupV2(pid string) ([]string, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer f.Close()
+	defer f.Close() //nolint:errcheck
 
 	scanner := bufio.NewScanner(f)
 	cgroupSlice := ""
@@ -152,7 +152,7 @@ func getPIDsFromCgroupV2(pid string) ([]string, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer f.Close()
+	defer f.Close() //nolint:errcheck
 
 	pids := []string{}
 	scanner = bufio.NewScanner(f)

psgo.go

@@ -425,7 +425,7 @@ func JoinNamespaceAndProcessInfoWithOptions(pid string, descriptors []string, op
 			dataErr = err
 			return
 		}
-		defer fd.Close()
+		defer fd.Close() //nolint:errcheck
 
 		// create a new mountns on the current thread
 		if err = unix.Unshare(unix.CLONE_NEWNS); err != nil {

sample/sample.go

@@ -67,7 +67,7 @@ func main() {
 
 	tw := tabwriter.NewWriter(os.Stdout, 5, 1, 3, ' ', 0)
 	for _, d := range data {
-		fmt.Fprintln(tw, strings.Join(d, "\t"))
+		_, _ = fmt.Fprintln(tw, strings.Join(d, "\t"))
 	}
-	tw.Flush()
+	_ = tw.Flush()
 }