ICS04: adds event emission in recvPacket to align with implementation#844
Merged
Conversation
crodriguezvega
requested review from
AdityaSripal,
colin-axner,
cwgoes and
mpoke
as code owners
crodriguezvega
commented
Oct 1, 2022
| // it's the sentinel success receipt: []byte{0x01} | ||
| abortTransactionUnless(provableStore.get(packetReceiptPath(packet.destPort, packet.destChannel, packet.sequence) === null)) | ||
| packetRecepit = provableStore.get(packetReceiptPath(packet.destPort, packet.destChannel, packet.sequence)) | ||
| if (packetRecepit != null) { |
Contributor
Author
There was a problem hiding this comment.
I noticed that we are also emitting an event in this case in ibc-go, so I added it here as well. I hope that's ok.
crodriguezvega
commented
Oct 1, 2022
| // log that a packet has been received | ||
| emitLogEntry("recvPacket", {sequence: packet.sequence, timeoutHeight: packet.timeoutHeight, port: packet.destPort, channel: packet.destChannel, | ||
| timeoutTimestamp: packet.timeoutTimestamp, data: packet.data}) | ||
| emitLogEntry("recvPacket", { |
Contributor
Author
There was a problem hiding this comment.
I thought it would help readability to break the long line...
…ent-for-already-received-packets-on-ordered-channels
mpoke
approved these changes
Oct 12, 2022
Contributor
mpoke
left a comment
mpoke
left a comment
There was a problem hiding this comment.
LGTM. Just some nits. See comments below.
…ent-for-already-received-packets-on-ordered-channels
AdityaSripal
approved these changes
Oct 24, 2022
crodriguezvega
deleted the
carlos/755-ics4-recvpacket-should-emit-an-event-for-already-received-packets-on-ordered-channels
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #755