Only check staged content in pre-hooks#916
Draft
Emilgardis wants to merge 2 commits into
Draft
Conversation
Emilgardis
force-pushed
the
hook-stash
branch
4 times, most recently
from
1ded0d8 to
4aa88c0
Compare
Alexhuszagh
reviewed
Jul 6, 2022
| git diff --full-index --binary > "$tf" | ||
| git stash -q --keep-index | ||
|
|
||
| trap cleanup EXIT |
Contributor
There was a problem hiding this comment.
This won't work on SIGKILL or SIGSTOP, which would lead to data lost. It also doesn't work for new files, which would mean they would be tests but not staged. There probably needs to be some means of recover (consistent file naming, a script to undo the last action in the Git history, something).
Contributor
There was a problem hiding this comment.
A simple example is:
$ echo "Sample contents" > file
$ git diff --full-index --binary # no output
$ git stash -q --keep-index # doesn't stash anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.