Skip to content

feat(dpp)!: lower indexed string properties constraints#273

Merged
jawid-h merged 4 commits into
v0.22-devfrom
feat/lower-size-constraints
Mar 4, 2022
Merged

feat(dpp)!: lower indexed string properties constraints#273
jawid-h merged 4 commits into
v0.22-devfrom
feat/lower-size-constraints

Conversation

@jawid-h
Copy link
Copy Markdown
Contributor

@jawid-h jawid-h commented Mar 4, 2022

Issue being fixed or feature implemented

Temporarily lowering constraints of indexed string properties due to the way how grovedb works internally.

What was done?

  • lowered constraints to 64 characters or 256 bytes

How Has This Been Tested?

  • unit tests

Breaking Changes

  • old contract schemas that have indexed string properties of longer length are no longer valid
  • DPNS now supports only cut versions of domain names due to lower constraints

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

shuplenkov
shuplenkov previously approved these changes Mar 4, 2022
@shuplenkov shuplenkov changed the title feat(dpp)!: lower indexed string proprties constraints feat(dpp)!: lower indexed string properties constraints Mar 4, 2022
@jawid-h jawid-h merged commit ab6391f into v0.22-dev Mar 4, 2022
@jawid-h jawid-h deleted the feat/lower-size-constraints branch March 4, 2022 15:45
@thephez thephez added this to the v0.22.0 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants