Skip to content

Commit c46d800

Browse files
atilafassinaatilafassina
committed
chore: update tests
1 parent 3e53787 commit c46d800

File tree

3 files changed

+157
-173
lines changed

3 files changed

+157
-173
lines changed

‎apps/dev-playground/client/src/appKitTypes.d.ts‎

Lines changed: 152 additions & 154 deletions
Original file line numberDiff line numberDiff line change
@@ -1,177 +1,175 @@
11
// Auto-generated by AppKit - DO NOT EDIT
22
// Generated by 'npx @databricks/appkit generate-types' or Vite plugin during build
33
import "@databricks/appkit-ui/react";
4-
import type { SQLTypeMarker, SQLStringMarker, SQLNumberMarker, SQLBooleanMarker, SQLBinaryMarker, SQLDateMarker, SQLTimestampMarker } from "@databricks/appkit-ui/js";
4+
import type {
5+
SQLTypeMarker,
6+
SQLStringMarker,
7+
SQLNumberMarker,
8+
SQLBooleanMarker,
9+
SQLBinaryMarker,
10+
SQLDateMarker,
11+
SQLTimestampMarker,
12+
} from "@databricks/appkit-ui/js";
513

614
declare module "@databricks/appkit-ui/react" {
715
interface QueryRegistry {
816
app_activity_heatmap: {
9-
name: "app_activity_heatmap";
10-
parameters: {
11-
/** DATE - use sql.date() */
12-
startDate: SQLDateMarker;
13-
/** DATE - use sql.date() */
14-
endDate: SQLDateMarker;
15-
};
16-
result: Array<{
17-
/** @sqlType STRING */
18-
app_name: string;
19-
/** @sqlType STRING */
20-
day_of_week: string;
21-
/** @sqlType DECIMAL(35,2) */
22-
spend: number;
23-
}>;
17+
name: "app_activity_heatmap";
18+
parameters: {
19+
/** DATE - use sql.date() */
20+
startDate: SQLDateMarker;
21+
/** DATE - use sql.date() */
22+
endDate: SQLDateMarker;
2423
};
24+
result: Array<{
25+
/** @sqlType STRING */
26+
app_name: string;
27+
/** @sqlType STRING */
28+
day_of_week: string;
29+
/** @sqlType DECIMAL(35,2) */
30+
spend: number;
31+
}>;
32+
};
2533
apps_list: {
26-
name: "apps_list";
27-
parameters: Record<string, never>;
28-
result: Array<{
29-
/** @sqlType STRING */
30-
id: string;
31-
/** @sqlType STRING */
32-
name: string;
33-
/** @sqlType STRING */
34-
creator: string;
35-
/** @sqlType STRING */
36-
tags: string;
37-
/** @sqlType DECIMAL(38,6) */
38-
totalSpend: number;
39-
/** @sqlType DATE */
40-
createdAt: string;
41-
}>;
42-
};
34+
name: "apps_list";
35+
parameters: Record<string, never>;
36+
result: Array<{
37+
/** @sqlType STRING */
38+
id: string;
39+
/** @sqlType STRING */
40+
name: string;
41+
/** @sqlType STRING */
42+
creator: string;
43+
/** @sqlType STRING */
44+
tags: string;
45+
/** @sqlType DECIMAL(38,6) */
46+
totalSpend: number;
47+
/** @sqlType DATE */
48+
createdAt: string;
49+
}>;
50+
};
4351
cost_recommendations: {
44-
name: "cost_recommendations";
45-
parameters: Record<string, never>;
46-
result: Array<{
47-
/** @sqlType INT */
48-
dummy: number;
49-
}>;
50-
};
52+
name: "cost_recommendations";
53+
parameters: Record<string, never>;
54+
result: Array<{
55+
/** @sqlType INT */
56+
dummy: number;
57+
}>;
58+
};
5159
example: {
52-
name: "example";
53-
parameters: Record<string, never>;
54-
result: Array<{
55-
/** @sqlType BOOLEAN */
56-
"(1 = 1)": boolean;
57-
}>;
58-
};
60+
name: "example";
61+
parameters: Record<string, never>;
62+
result: unknown;
63+
};
5964
spend_data: {
60-
name: "spend_data";
61-
parameters: {
62-
/** STRING - use sql.string() */
63-
groupBy: SQLStringMarker;
64-
/** STRING - use sql.string() */
65-
aggregationLevel: SQLStringMarker;
66-
/** DATE - use sql.date() */
67-
startDate: SQLDateMarker;
68-
/** DATE - use sql.date() */
69-
endDate: SQLDateMarker;
70-
/** STRING - use sql.string() */
71-
appId: SQLStringMarker;
72-
/** STRING - use sql.string() */
73-
creator: SQLStringMarker;
74-
};
75-
result: Array<{
76-
/** @sqlType STRING */
77-
group_key: string;
78-
/** @sqlType TIMESTAMP */
79-
aggregation_period: string;
80-
/** @sqlType DECIMAL(38,6) */
81-
cost_usd: number;
82-
}>;
65+
name: "spend_data";
66+
parameters: {
67+
/** STRING - use sql.string() */
68+
groupBy: SQLStringMarker;
69+
/** STRING - use sql.string() */
70+
aggregationLevel: SQLStringMarker;
71+
/** DATE - use sql.date() */
72+
startDate: SQLDateMarker;
73+
/** DATE - use sql.date() */
74+
endDate: SQLDateMarker;
75+
/** STRING - use sql.string() */
76+
appId: SQLStringMarker;
77+
/** STRING - use sql.string() */
78+
creator: SQLStringMarker;
8379
};
80+
result: Array<{
81+
/** @sqlType STRING */
82+
group_key: string;
83+
/** @sqlType TIMESTAMP */
84+
aggregation_period: string;
85+
/** @sqlType DECIMAL(38,6) */
86+
cost_usd: number;
87+
}>;
88+
};
8489
spend_summary: {
85-
name: "spend_summary";
86-
parameters: {
87-
/** STRING - use sql.string() */
88-
aggregationLevel: SQLStringMarker;
89-
/** DATE - use sql.date() */
90-
endDate: SQLDateMarker;
91-
/** DATE - use sql.date() */
92-
startDate: SQLDateMarker;
93-
};
94-
result: Array<{
95-
/** @sqlType DECIMAL(33,0) */
96-
total: number;
97-
/** @sqlType DECIMAL(33,0) */
98-
average: number;
99-
/** @sqlType DECIMAL(33,0) */
100-
forecasted: number;
101-
}>;
90+
name: "spend_summary";
91+
parameters: {
92+
/** STRING - use sql.string() */
93+
aggregationLevel: SQLStringMarker;
94+
/** DATE - use sql.date() */
95+
endDate: SQLDateMarker;
96+
/** DATE - use sql.date() */
97+
startDate: SQLDateMarker;
10298
};
99+
result: unknown;
100+
};
103101
sql_helpers_test: {
104-
name: "sql_helpers_test";
105-
parameters: {
106-
/** STRING - use sql.string() */
107-
stringParam: SQLStringMarker;
108-
/** NUMERIC - use sql.number() */
109-
numberParam: SQLNumberMarker;
110-
/** BOOLEAN - use sql.boolean() */
111-
booleanParam: SQLBooleanMarker;
112-
/** DATE - use sql.date() */
113-
dateParam: SQLDateMarker;
114-
/** TIMESTAMP - use sql.timestamp() */
115-
timestampParam: SQLTimestampMarker;
116-
/** STRING - use sql.string() */
117-
binaryParam: SQLStringMarker;
118-
};
119-
result: Array<{
120-
/** @sqlType STRING */
121-
string_value: string;
122-
/** @sqlType STRING */
123-
number_value: string;
124-
/** @sqlType STRING */
125-
boolean_value: string;
126-
/** @sqlType STRING */
127-
date_value: string;
128-
/** @sqlType STRING */
129-
timestamp_value: string;
130-
/** @sqlType BINARY */
131-
binary_value: string;
132-
/** @sqlType STRING */
133-
binary_hex: string;
134-
/** @sqlType INT */
135-
binary_length: number;
136-
}>;
102+
name: "sql_helpers_test";
103+
parameters: {
104+
/** STRING - use sql.string() */
105+
stringParam: SQLStringMarker;
106+
/** NUMERIC - use sql.number() */
107+
numberParam: SQLNumberMarker;
108+
/** BOOLEAN - use sql.boolean() */
109+
booleanParam: SQLBooleanMarker;
110+
/** DATE - use sql.date() */
111+
dateParam: SQLDateMarker;
112+
/** TIMESTAMP - use sql.timestamp() */
113+
timestampParam: SQLTimestampMarker;
114+
/** STRING - use sql.string() */
115+
binaryParam: SQLStringMarker;
137116
};
117+
result: Array<{
118+
/** @sqlType STRING */
119+
string_value: string;
120+
/** @sqlType STRING */
121+
number_value: string;
122+
/** @sqlType STRING */
123+
boolean_value: string;
124+
/** @sqlType STRING */
125+
date_value: string;
126+
/** @sqlType STRING */
127+
timestamp_value: string;
128+
/** @sqlType BINARY */
129+
binary_value: string;
130+
/** @sqlType STRING */
131+
binary_hex: string;
132+
/** @sqlType INT */
133+
binary_length: number;
134+
}>;
135+
};
138136
top_contributors: {
139-
name: "top_contributors";
140-
parameters: {
141-
/** STRING - use sql.string() */
142-
aggregationLevel: SQLStringMarker;
143-
/** DATE - use sql.date() */
144-
startDate: SQLDateMarker;
145-
/** DATE - use sql.date() */
146-
endDate: SQLDateMarker;
147-
};
148-
result: Array<{
149-
/** @sqlType STRING */
150-
app_name: string;
151-
/** @sqlType DECIMAL(38,6) */
152-
total_cost_usd: number;
153-
}>;
137+
name: "top_contributors";
138+
parameters: {
139+
/** STRING - use sql.string() */
140+
aggregationLevel: SQLStringMarker;
141+
/** DATE - use sql.date() */
142+
startDate: SQLDateMarker;
143+
/** DATE - use sql.date() */
144+
endDate: SQLDateMarker;
154145
};
146+
result: Array<{
147+
/** @sqlType STRING */
148+
app_name: string;
149+
/** @sqlType DECIMAL(38,6) */
150+
total_cost_usd: number;
151+
}>;
152+
};
155153
untagged_apps: {
156-
name: "untagged_apps";
157-
parameters: {
158-
/** STRING - use sql.string() */
159-
aggregationLevel: SQLStringMarker;
160-
/** DATE - use sql.date() */
161-
startDate: SQLDateMarker;
162-
/** DATE - use sql.date() */
163-
endDate: SQLDateMarker;
164-
};
165-
result: Array<{
166-
/** @sqlType STRING */
167-
app_name: string;
168-
/** @sqlType STRING */
169-
creator: string;
170-
/** @sqlType DECIMAL(38,6) */
171-
total_cost_usd: number;
172-
/** @sqlType DECIMAL(38,10) */
173-
avg_period_cost_usd: number;
174-
}>;
154+
name: "untagged_apps";
155+
parameters: {
156+
/** STRING - use sql.string() */
157+
aggregationLevel: SQLStringMarker;
158+
/** DATE - use sql.date() */
159+
startDate: SQLDateMarker;
160+
/** DATE - use sql.date() */
161+
endDate: SQLDateMarker;
175162
};
163+
result: Array<{
164+
/** @sqlType STRING */
165+
app_name: string;
166+
/** @sqlType STRING */
167+
creator: string;
168+
/** @sqlType DECIMAL(38,6) */
169+
total_cost_usd: number;
170+
/** @sqlType DECIMAL(38,10) */
171+
avg_period_cost_usd: number;
172+
}>;
173+
};
176174
}
177175
}

‎packages/appkit/src/type-generator/query-registry.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,8 +336,8 @@ export async function generateQueriesFromDescribe(
336336
for (const entry of logEntries) {
337337
const tag =
338338
entry.status === "HIT"
339-
? `cache ${pc.green("HIT ")}`
340-
: `cache ${pc.red("MISS")}`;
339+
? `cache ${pc.bold(pc.green("HIT "))}`
340+
: `cache ${pc.bold(pc.red("MISS"))}`;
341341
const name = entry.failed
342342
? pc.dim(pc.strikethrough(entry.queryName))
343343
: entry.queryName;

‎packages/appkit/src/type-generator/tests/generate-queries.test.ts‎

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ describe("generateQueriesFromDescribe", () => {
7070
expect(schemas[0].name).toBe("users");
7171
expect(schemas[0].type).toContain("id: number");
7272
expect(schemas[0].type).toContain("name: string");
73-
expect(mocks.spinnerStop).toHaveBeenCalledWith("✓ Described 1 query");
74-
expect(mocks.spinnerPrintDetail).toHaveBeenCalledWith("✓ users");
73+
expect(mocks.spinnerStop).toHaveBeenCalledWith("");
7574
expect(mocks.saveCache).toHaveBeenCalledTimes(1);
7675
});
7776

@@ -91,16 +90,7 @@ describe("generateQueriesFromDescribe", () => {
9190
expect(schemas).toHaveLength(1);
9291
expect(schemas[0].name).toBe("bad_table");
9392
expect(schemas[0].type).toContain("result: unknown");
94-
expect(mocks.spinnerStop).toHaveBeenCalledWith("✓ Described 1 query");
95-
expect(mocks.spinnerPrintDetail).toHaveBeenCalledWith(
96-
"✗ bad_table - failed",
97-
);
98-
expect(mocks.spinnerPrintDetail).toHaveBeenCalledWith(
99-
expect.stringContaining("SQL Error: Table or view not found: bad_table"),
100-
);
101-
expect(mocks.spinnerPrintDetail).toHaveBeenCalledWith(
102-
expect.stringContaining("Query:"),
103-
);
93+
expect(mocks.spinnerStop).toHaveBeenCalledWith("");
10494
expect(mocks.saveCache).toHaveBeenCalledTimes(1);
10595
});
10696

@@ -117,11 +107,7 @@ describe("generateQueriesFromDescribe", () => {
117107
expect(schemas).toHaveLength(1);
118108
expect(schemas[0].name).toBe("query");
119109
expect(schemas[0].type).toContain("result: unknown");
120-
expect(mocks.spinnerStop).toHaveBeenCalledWith("✓ Described 1 query");
121-
expect(mocks.spinnerPrintDetail).toHaveBeenCalledWith("✗ query - failed");
122-
expect(mocks.spinnerPrintDetail).toHaveBeenCalledWith(
123-
expect.stringContaining("SQL Error: Query execution failed"),
124-
);
110+
expect(mocks.spinnerStop).toHaveBeenCalledWith("");
125111
expect(mocks.saveCache).toHaveBeenCalledTimes(1);
126112
});
127113

0 commit comments

Comments
 (0)