Throw error if model contract enforced#322
Merged
susodapop merged 5 commits intoMay 1, 2023
Merged
Conversation
rcypher-databricks
requested review from
andrefurlan-db,
susodapop and
ueshin
as code owners
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Until we support dbt 1.5 model contracts we will throw an error if contract->enforced is set to true for a model. Added doc outlining differences between dbt-databricks constraints and dbt model contract. Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
rcypher-databricks
force-pushed
the
model_contract
branch
from
88c7b04 to
b691871
Compare
rcypher-databricks
changed the base branch from
main
to
make-integration-tests-work
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
susodapop
approved these changes
May 1, 2023
susodapop
left a comment
susodapop
left a comment
There was a problem hiding this comment.
This is ready to merge to the staging branch so we can run the integration tests.
andrefurlan-db
pushed a commit
that referenced
this pull request
May 2, 2023
* Mirror of dbt-databricks#319 but rebased on 1.5.test branch Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Throw error if model contract enforced Until we support dbt 1.5 model contracts we will throw an error if contract->enforced is set to true for a model. Added doc outlining differences between dbt-databricks constraints and dbt model contract. Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> * Update change log Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> * added missing newline Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> * Add all columns to model definition Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> --------- Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> Co-authored-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
rcypher-databricks
added a commit
to rcypher-databricks/dbt-databricks
that referenced
this pull request
May 8, 2023
* Mirror of dbt-databricks#319 but rebased on 1.5.test branch Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Throw error if model contract enforced Until we support dbt 1.5 model contracts we will throw an error if contract->enforced is set to true for a model. Added doc outlining differences between dbt-databricks constraints and dbt model contract. Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> * Update change log Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> * added missing newline Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> * Add all columns to model definition Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> --------- Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> Co-authored-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
rcypher-databricks
added a commit
to rcypher-databricks/dbt-databricks
that referenced
this pull request
May 8, 2023
* Mirror of dbt-databricks#319 but rebased on 1.5.test branch Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Throw error if model contract enforced Until we support dbt 1.5 model contracts we will throw an error if contract->enforced is set to true for a model. Added doc outlining differences between dbt-databricks constraints and dbt model contract. Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> * Update change log Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> * added missing newline Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> * Add all columns to model definition Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> --------- Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com> Co-authored-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Until we support dbt 1.5 model contracts we will throw an error if contract->enforced is set to true for a model.
Added doc outlining differences between dbt-databricks constraints and dbt model contract.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.