Make integration tests work with dbt==1.5#323
Merged
Conversation
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
temporarily deployed
to
azure-prod-pecou
GitHub Actions
Inactive
susodapop
temporarily deployed
to
azure-prod-peco
GitHub Actions
Inactive
added 2 commits
May 1, 2023 11:12
This is failing because the new dbt-core test runner doesn't re-raise the initial FailFastException as of dbt-core==1.5.0rc2 Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
integration tests. This is a mirror of: https: //github.com/dbt-labs/dbt-spark/pull/698 Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
force-pushed
the
make-integration-tests-work
branch
from
9b2de74 to
b5a9732
Compare
andrefurlan-db
pushed a commit
that referenced
this pull request
May 2, 2023
* Mirror of dbt-databricks#319 but rebased on 1.5.test branch * Fix: test_fail_fast failure This is failing because the new dbt-core test runner doesn't re-raise the initial FailFastException as of dbt-core==1.5.0rc2 * Fix: log message in `impl.py` completely breaks docs generation for integration tests. This is a mirror of: https: //github.com/dbt-labs/dbt-spark/pull/698 Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
rcypher-databricks
pushed a commit
to rcypher-databricks/dbt-databricks
that referenced
this pull request
May 8, 2023
* Mirror of dbt-databricks#319 but rebased on 1.5.test branch * Fix: test_fail_fast failure This is failing because the new dbt-core test runner doesn't re-raise the initial FailFastException as of dbt-core==1.5.0rc2 * Fix: log message in `impl.py` completely breaks docs generation for integration tests. This is a mirror of: https: //github.com/dbt-labs/dbt-spark/pull/698 Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #
Description
This pull request starts by implementing the patch of #319 atop our v1.5.x branch. The goal is for all existing integration tests to pass without (yet) migrating to the new pytest style tests and fixtures.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.