Skip to content

Update m2m OAuth scopes to not include offline_access. #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benc-db merged 2 commits into from
Sep 11, 2023
Merged

Update m2m OAuth scopes to not include offline_access. #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0770d41
update m2m to not include offline_access. Per Jacky, it is not neede…
benc-db Sep 11, 2023
2fcd5a4
Updating CHANGELOG
benc-db Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
## dbt-databricks 1.6.x (Release TBD)

### Fixes

- Fixed an issue with AWS OAuth M2M flow ([#445](https://github.com/databricks/dbt-databricks/pull/445))

## dbt-databricks 1.6.3 (September 8, 2023)

### Fixes
Expand Down
4 changes: 2 additions & 2 deletions dbt/adapters/databricks/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ def noop_credentials(_: Any): # type: ignore

config = Config(host=host, credentials_provider=noop_credentials)
oidc = config.oidc_endpoints
scopes = ["offline_access", "all-apis"]
scopes = ["all-apis"]
if not oidc:
raise ValueError(f"{host} does not support OAuth")
if config.is_azure:
# Azure AD only supports full access to Azure Databricks.
scopes = [f"{config.effective_azure_login_app_id}/.default", "offline_access"]
scopes = [f"{config.effective_azure_login_app_id}/.default"]
self._token_source = ClientCredentials(
client_id=client_id,
client_secret=client_secret,
Expand Down