tests: refactor tests to use MockCommon helpers

Author: datamweb

system/Debug/Toolbar.php

@@ -392,15 +392,6 @@ public function prepare(?RequestInterface $request = null, ?ResponseInterface $r
 
             $config = config(ToolbarConfig::class);
 
-            try {
-                $stats = $app->getPerformanceStats();
-                if (! isset($stats['startTime']) || ! isset($stats['totalTime'])) {
-                    return;
-                }
-            } catch (Throwable) {
-                return;
-            }
-
             foreach ($config->disableOnHeaders as $header) {
                 if ($request->hasHeader($header)) {
                     $this->isCustomAjax = true;
@@ -409,6 +400,7 @@ public function prepare(?RequestInterface $request = null, ?ResponseInterface $r
             }
 
             $toolbar = service('toolbar', $config);
+            $stats = $app->getPerformanceStats();
             $data    = $toolbar->run(
                 $stats['startTime'],
                 $stats['totalTime'],

tests/system/Debug/ToolbarTest.php

@@ -33,12 +33,16 @@ final class ToolbarTest extends CIUnitTestCase
     private ToolbarConfig $config;
     private ?IncomingRequest $request    = null;
     private ?ResponseInterface $response = null;
+    private bool $originalIsCli;
 
     protected function setUp(): void
     {
         parent::setUp();
         Services::reset();
 
+        $this->originalIsCli = is_cli();
+        is_cli(false);
+
         $this->config = new ToolbarConfig();
 
         // Mock CodeIgniter core service to provide performance stats
@@ -50,6 +54,14 @@ protected function setUp(): void
         Services::injectMock('codeigniter', $app);
     }
 
+    protected function tearDown(): void
+    {
+        // Restore original is_cli state
+        is_cli($this->originalIsCli);
+
+        parent::tearDown();
+    }
+
     public function testPrepareRespectsDisableOnHeaders(): void
     {
         // Set up the new configuration property
@@ -90,11 +102,3 @@ public function testPrepareInjectsNormallyWithoutIgnoredHeader(): void
         $this->assertStringContainsString('id="debugbar_loader"', (string) $this->response->getBody());
     }
 }
-
-/**
- * Mock is_cli() to return false within this namespace.
- */
-function is_cli(): bool
-{
-    return false;
-}