This repository was archived by the owner on Sep 2, 2025. It is now read-only.
Move code quality deps to precommit#1291
Merged
Merged
Conversation
Contributor
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We wind up with a ton of dependabot updates, most of them for linting dependencies. We also have two versions of linting config, one in
.pre-commit-config.yamland one in separate config files. Since we generally run linting viapre-commit, the latter doesn't get used.Solution
.pre-commit-config.yamlpre-commit runinstead of calling directly (the tools will no longer be in the virtual environment)pre-commit run --all-filesChecklist