fix: Use simple v* tag format for releases#62
Merged
Conversation
Add include-component-in-tag: false to Release Please config so tags are created as v0.4.3 instead of llmkubev0.4.3. This matches the existing release.yml workflow trigger pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
include-component-in-tag: falseto Release Please config so tags are created asv0.4.3instead ofllmkubev0.4.3.Problem
Release Please was creating tags like
llmkubev0.4.2but the release.yml workflow triggers onv*.*.*pattern, so builds weren't running.Solution
Set
include-component-in-tag: falsein release-please-config.json.Test plan
v0.4.3format