wpad2: don't issue status commands if rumble is already set

mardy · mardy · commit e6deb57a5ca8 · 2026-03-12T21:32:13.000+03:00
diff --git a/wpad2/device.c b/wpad2/device.c
@@ -680,9 +680,11 @@ void _wpad2_device_timer_event(uint64_t now)
 
 void _wpad2_device_set_rumble(WpadDevice *device, bool enable)
 {
-	WPAD2_DEBUG("enable: %d", enable);
-	device->rumble = enable;
-	_wpad2_device_request_status(device);
+	if (enable != device->rumble) {
+		WPAD2_DEBUG("enable: %d", enable);
+		device->rumble = enable;
+		_wpad2_device_request_status(device);
+	}
 }
 
 void _wpad2_device_set_speaker(WpadDevice *device, bool enable)
diff --git a/wpad2/internals.h b/wpad2/internals.h
@@ -33,7 +33,7 @@
 #define absf(x)                     ((x >= 0) ? (x) : (x * -1.0f))
 #define diff_f(x, y)                ((x >= y) ? (absf(x - y)) : (absf(y - x)))
 
-//#define WITH_WPAD_DEBUG
+#define WITH_WPAD_DEBUG
 
 #ifdef WITH_WPAD_DEBUG
 	#define WPAD2_DEBUG(fmt, ...)  SYS_Report("[DEBUG] %s:%i: " fmt "\n", __func__, __LINE__, ##__VA_ARGS__)

Original file line number	Diff line number	Diff line change
`@@ -680,9 +680,11 @@ void _wpad2_device_timer_event(uint64_t now)`
`680`	`680`
`681`	`681`	`void _wpad2_device_set_rumble(WpadDevice *device, bool enable)`
`682`	`682`	`{`
`683`		`- WPAD2_DEBUG("enable: %d", enable);`
`684`		`- device->rumble = enable;`
`685`		`- _wpad2_device_request_status(device);`
	`683`	`+ if (enable != device->rumble) {`
	`684`	`+ WPAD2_DEBUG("enable: %d", enable);`
	`685`	`+ device->rumble = enable;`
	`686`	`+ _wpad2_device_request_status(device);`
	`687`	`+ }`
`686`	`688`	`}`
`687`	`689`
`688`	`690`	`void _wpad2_device_set_speaker(WpadDevice *device, bool enable)`