Switch from Ubuntu to Debian

Specifically, from Ubuntu Jammy (22.04; EOL in 2027) to Debian Bookworm (12; EOL in 2028).

Ideally we would upgrade to Debian Trixie (13; EOL in 2030), but that gets us too new of a Python for `cqlsh` 😔

Author: tianon

4.0/Dockerfile

@@ -1,4 +1,4 @@
-FROM {{ .FROM.version }}
+FROM debian:bookworm-slim
 
 # explicitly set user/group IDs
 RUN set -eux; \
@@ -50,6 +50,11 @@ RUN set -eux; \
 	gosu --version; \
 	gosu nobody true
 
+ENV JAVA_HOME /opt/java/openjdk
+COPY --from=eclipse-temurin:{{ .java.version }}-jre $JAVA_HOME $JAVA_HOME
+ENV PATH $JAVA_HOME/bin:$PATH
+RUN java --version
+
 ENV CASSANDRA_HOME /opt/cassandra
 ENV CASSANDRA_CONF /etc/cassandra
 ENV PATH $CASSANDRA_HOME/bin:$PATH

4.1/Dockerfile

@@ -39,18 +39,36 @@ dirCommit() {
 	)
 }
 
+gawkParents='
+	{ cmd = toupper($1) }
+	cmd == "FROM" {
+		print $2
+		next
+	}
+	cmd == "COPY" {
+		for (i = 2; i < NF; i++) {
+			if ($i ~ /^--from=/) {
+				gsub(/^--from=/, "", $i)
+				print $i
+				next
+			}
+		}
+	}
+'
+
 getArches() {
 	local repo="$1"; shift
 	local officialImagesBase="${BASHBREW_LIBRARY:-https://github.com/docker-library/official-images/raw/HEAD/library}/"
 
 	local parentRepoToArchesStr
 	parentRepoToArchesStr="$(
-		find -name 'Dockerfile' -exec awk -v officialImagesBase="$officialImagesBase" '
-				toupper($1) == "FROM" && $2 !~ /^('"$repo"'|scratch|.*\/.*)(:|$)/ {
-					printf "%s%s\n", officialImagesBase, $2
-				}
-			' '{}' + \
+		find -name 'Dockerfile' -exec gawk "$gawkParents" '{}' + \
 			| sort -u \
+			| gawk -v officialImagesBase="$officialImagesBase" '
+				$1 !~ /^('"$repo"'|scratch|.*\/.*)(:|$)/ {
+					printf "%s%s\n", officialImagesBase, $1
+				}
+			' \
 			| xargs -r bashbrew cat --format '["{{ .RepoName }}:{{ .TagName }}"]="{{ join " " .TagEntry.Architectures }}"'
 	)"
 	eval "declare -g -A parentRepoToArches=( $parentRepoToArchesStr )"
@@ -83,13 +101,27 @@ for version; do
 	fi
 	versionAliases+=( ${aliases[$version]:-} )
 
-	suite="$(jq -r '.[env.version].FROM.base' versions.json)"
+	suite="$(jq -r '.[env.version].debian.version' versions.json)"
 	suiteAliases=( "${versionAliases[@]/%/-$suite}" )
 	suiteAliases=( "${suiteAliases[@]//latest-/}" )
 	versionAliases+=( "${suiteAliases[@]}" )
 
-	parent="$(awk 'toupper($1) == "FROM" { print $2 }' "$version/Dockerfile")"
-	arches="${parentRepoToArches[$parent]}"
+	parents="$(gawk "$gawkParents" "$version/Dockerfile")"
+	arches=
+	for parent in $parents; do
+		parentArches="${parentRepoToArches[$parent]:-}"
+		if [ -z "$parentArches" ]; then
+			continue
+		elif [ -z "$arches" ]; then
+			arches="$parentArches"
+		else
+			arches="$(
+				comm -12 \
+					<(xargs -n1 <<<"$arches" | sort -u) \
+					<(xargs -n1 <<<"$parentArches" | sort -u)
+			)"
+		fi
+	done
 
 	commit="$(dirCommit "$version")"
 

5.0/Dockerfile

@@ -5,9 +5,8 @@
     "java": {
       "version": "11"
     },
-    "FROM": {
-      "version": "eclipse-temurin:11-jre-jammy",
-      "base": "jammy"
+    "debian": {
+      "version": "bookworm"
     }
   },
   "4.1": {
@@ -16,9 +15,8 @@
     "java": {
       "version": "11"
     },
-    "FROM": {
-      "version": "eclipse-temurin:11-jre-jammy",
-      "base": "jammy"
+    "debian": {
+      "version": "bookworm"
     }
   },
   "5.0": {
@@ -27,9 +25,8 @@
     "java": {
       "version": "17"
     },
-    "FROM": {
-      "version": "eclipse-temurin:17-jre-jammy",
-      "base": "jammy"
+    "debian": {
+      "version": "bookworm"
     }
   }
 }

Dockerfile.template

@@ -3,20 +3,22 @@ set -Eeuo pipefail
 
 # https://cassandra.apache.org/doc/5.0/cassandra/installing/installing.html#prerequisites
 # https://cassandra.apache.org/doc/4.1/cassandra/getting_started/installing.html#prerequisites
+# https://github.com/apache/cassandra/blob/cassandra-5.0.6/build.xml#L48
 defaultJavaVersion='17'
 declare -A javaVersions=(
-	[4.0]='11'
-	[4.1]='11'
+	[4.0]='11' # https://github.com/apache/cassandra/blob/cassandra-4.0.19/build.xml#L212-L221
+	[4.1]='11' # https://github.com/apache/cassandra/blob/cassandra-4.1.10/build.xml#L227-L236
 )
-declare -A suiteOverrides=(
+defaultSuite='trixie'
+declare -A suites=(
 	# https://issues.apache.org/jira/browse/CASSANDRA-19206: "cqlsh breaks with Python 3.12" ("ModuleNotFoundError: No module named 'six.moves'")
-	[4.0]='jammy'
-	[4.1]='jammy'
+	[4.0]='bookworm'
+	[4.1]='bookworm'
 	# "Warning: unsupported version of Python, required 3.6-3.11 but found 3.12"
 	# https://github.com/apache/cassandra/commit/8fd44ca8fc9e0b0e94932bcd855e2833bf6ca3cb#diff-8d8ae48aaf489a8a0e726d3e4a6230a26dcc76e7c739e8e3968e3f65c995d148
 	# https://issues.apache.org/jira/browse/CASSANDRA-19245?focusedCommentId=17803539#comment-17803539
 	# https://github.com/apache/cassandra/blob/cassandra-5.0.6/bin/cqlsh#L65
-	[5.0]='jammy'
+	[5.0]='bookworm'
 )
 
 cd "$(dirname "$(readlink -f "$BASH_SOURCE")")"
@@ -55,18 +57,10 @@ for version in "${versions[@]}"; do
 	fi
 	export fullVersion sha512
 
-	export javaVersion="${javaVersions[$version]:-$defaultJavaVersion}"
-	suiteOverride="${suiteOverrides[$version]:-}"
+	export javaVersion="${javaVersions[$version]:-$defaultJavaVersion}" # TODO scrape this from build.xml upstream directly?
+	export suite="${suites[$version]:-$defaultSuite}"
 
-	# for the given Java version, find the "default" Eclipse Temurin tag with stable specificity ("X-jre-SUITE")
-	from="$(
-		bashbrew --arch amd64 list --arch-filter "https://github.com/docker-library/official-images/raw/HEAD/library/eclipse-temurin:$javaVersion-jre${suiteOverride:+-$suiteOverride}" \
-			| grep -F ":$javaVersion-jre-" \
-			| tail -1
-	)"
-	export from
-
-	echo "$version: $fullVersion (FROM $from)"
+	echo "$version: $fullVersion"
 
 	json="$(jq <<<"$json" -c '
 		.[env.version] = {
@@ -75,10 +69,8 @@ for version in "${versions[@]}"; do
 			java: {
 				version: env.javaVersion,
 			},
-			FROM: {
-				# this structure is a little bit awkward, but gives us nice commit messages like "Update 5.0 to FROM eclipse-temurin:17-jre-jammy"
-				version: env.from,
-				base: (env.from | split(":\(env.javaVersion)-jre-")[1]),
+			debian: {
+				version: env.suite,
 			},
 		}
 	')"