chore: fix IDE0028/IDE0300/IDE0301/IDE0303 that are reported by .NET analyzer (#3016)

* chore: fix IDE0028 that reported by analyzer

* chore: fix IDE0300, IDE0301, IDE0303

* Update tests/BenchmarkDotNet.Tests/CorrectionsSuggesterTests.cs

---------

Co-authored-by: Tim Cassell <cassell.timothy@gmail.com>

Author: filzrev

samples/BenchmarkDotNet.Samples/IntroComparableComplexParam.cs

@@ -9,7 +9,7 @@ public class IntroComparableComplexParam
         [ParamsSource(nameof(ValuesForA))]
         public ComplexParam? A { get; set; }
 
-        public IEnumerable<ComplexParam> ValuesForA => new[] { new ComplexParam(1, "First"), new ComplexParam(2, "Second") };
+        public IEnumerable<ComplexParam> ValuesForA => [new ComplexParam(1, "First"), new ComplexParam(2, "Second")];
 
         [Benchmark]
         public object? Benchmark() => A;

samples/BenchmarkDotNet.Samples/IntroCustomMonoArguments.cs

@@ -19,11 +19,11 @@ public ConfigWithCustomArguments()
 
                 AddJob(Job.Default
                     .WithRuntime(MonoRuntime.Default)
-                    .WithArguments(new[] { new MonoArgument("--optimize=inline") })
+                    .WithArguments([new MonoArgument("--optimize=inline")])
                     .WithId("Inlining enabled"));
                 AddJob(Job.Default
                     .WithRuntime(MonoRuntime.Default)
-                    .WithArguments(new[] { new MonoArgument("--optimize=-inline") })
+                    .WithArguments([new MonoArgument("--optimize=-inline")])
                     .WithId("Inlining disabled"));
             }
         }

samples/BenchmarkDotNet.Samples/IntroDeferredExecution.cs

@@ -7,7 +7,7 @@ namespace BenchmarkDotNet.Samples
 {
     public class IntroDeferredExecution
     {
-        private readonly int[] numbers = { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 };
+        private readonly int[] numbers = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
 
         private readonly Consumer consumer = new Consumer();
 

samples/BenchmarkDotNet.Samples/IntroInliningDiagnoser.cs

@@ -3,7 +3,7 @@
 
 namespace BenchmarkDotNet.Samples
 {
-    [Diagnostics.Windows.Configs.InliningDiagnoser(logFailuresOnly: false, allowedNamespaces: new[] { "BenchmarkDotNet.Samples" })]
+    [Diagnostics.Windows.Configs.InliningDiagnoser(logFailuresOnly: false, allowedNamespaces: ["BenchmarkDotNet.Samples"])]
     public class IntroInliningDiagnoser
     {
         [Benchmark]

samples/BenchmarkDotNet.Samples/IntroParamsSource.cs

@@ -15,10 +15,10 @@ public class IntroParamsSource
         public int B;
 
         // public property
-        public IEnumerable<int> ValuesForA => new[] { 100, 200 };
+        public IEnumerable<int> ValuesForA => [100, 200];
 
         // public static method
-        public static IEnumerable<int> ValuesForB() => new[] { 10, 20 };
+        public static IEnumerable<int> ValuesForB() => [10, 20];
 
         // public field getting its params from a method in another type
         [ParamsSource(typeof(ParamsValues), nameof(ParamsValues.ValuesForC))]
@@ -30,6 +30,6 @@ public class IntroParamsSource
 
     public static class ParamsValues
     {
-        public static IEnumerable<int> ValuesForC() => new[] { 1000, 2000 };
+        public static IEnumerable<int> ValuesForC() => [1000, 2000];
     }
 }

src/BenchmarkDotNet.Annotations/Attributes/ArgumentsAttribute.cs

@@ -10,9 +10,9 @@ public class ArgumentsAttribute : PriorityAttribute
 
         // CLS-Compliant Code requires a constructor without an array in the argument list
         [PublicAPI]
-        public ArgumentsAttribute() => Values = new object[0];
+        public ArgumentsAttribute() => Values = [];
 
         public ArgumentsAttribute(params object?[]? values)
-            => Values = values ?? new object?[] { null }; // when users do Arguments(null) they mean one, null argument
+            => Values = values ?? [null]; // when users do Arguments(null) they mean one, null argument
     }
 }

src/BenchmarkDotNet.Annotations/Attributes/BenchmarkCategoryAttribute.cs

@@ -9,7 +9,7 @@ public class BenchmarkCategoryAttribute : Attribute
         public string[] Categories { get; }
 
         // CLS-Compliant Code requires a constructor without an array in the argument list
-        [PublicAPI] protected BenchmarkCategoryAttribute() => Categories = new string[0];
+        [PublicAPI] protected BenchmarkCategoryAttribute() => Categories = [];
 
         public BenchmarkCategoryAttribute(params string[] categories) => Categories = categories;
     }

src/BenchmarkDotNet.Annotations/Attributes/GenericTypeArgumentsAttribute.cs

@@ -9,17 +9,17 @@ public class GenericTypeArgumentsAttribute : Attribute
         public Type[] GenericTypeArguments { get; }
 
         public GenericTypeArgumentsAttribute([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] Type type)
-            => GenericTypeArguments = new[] { type };
+            => GenericTypeArguments = [type];
 
         public GenericTypeArgumentsAttribute(
             [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] Type type1,
             [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] Type type2)
-            => GenericTypeArguments = new[] { type1, type2 };
+            => GenericTypeArguments = [type1, type2];
 
         public GenericTypeArgumentsAttribute(
             [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] Type type1,
             [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] Type type2,
             [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] Type type3)
-            => GenericTypeArguments = new[] { type1, type2, type3 };
+            => GenericTypeArguments = [type1, type2, type3];
     }
 }

src/BenchmarkDotNet.Annotations/Attributes/TargetedAttribute.cs

@@ -9,15 +9,15 @@ namespace BenchmarkDotNet.Attributes
     /// </summary>
     public abstract class TargetedAttribute : Attribute
     {
-        public string[] Targets { get; set; } = new string[0];
+        public string[] Targets { get; set; } = [];
 
         /// <summary>
         /// Target method for attribute
         /// </summary>
         public string Target
         {
             get => throw new InvalidOperationException("Please use Targets property"); // kept to keep compiler happy "Named attribute arguments must be fields which are not readonly, static, or const, or read-write properties which are public and not static."
-            set => Targets = string.IsNullOrEmpty(value) ? new string[0] : value.Split(','); // , is for backward compat
+            set => Targets = string.IsNullOrEmpty(value) ? [] : value.Split(','); // , is for backward compat
         }
 
         public bool Match(MethodInfo method) => Targets.Length == 0 || Targets.Contains(method.Name);

src/BenchmarkDotNet.Diagnostics.Windows/ConcurrencyVisualizerProfiler.cs

@@ -33,8 +33,8 @@ public class ConcurrencyVisualizerProfiler : IProfiler
         private static readonly Guid ConcurrencyVisualizerMarkersId = new Guid("8D4925AB-505A-483b-A7E0-6F824A07A6F0"); // "ConcurrencyVisualizer.Markers";
 
         private readonly EtwProfiler etwProfiler;
-        private readonly Dictionary<BenchmarkCase, string> benchmarkToCvTraceFile = new Dictionary<BenchmarkCase, string>();
-        private readonly Dictionary<BenchmarkCase, int> benchmarkToProcessId = new Dictionary<BenchmarkCase, int>();
+        private readonly Dictionary<BenchmarkCase, string> benchmarkToCvTraceFile = [];
+        private readonly Dictionary<BenchmarkCase, int> benchmarkToProcessId = [];
 
         [PublicAPI] // parameterless ctor required by DiagnosersLoader to support creating this profiler via console line args
         public ConcurrencyVisualizerProfiler() => etwProfiler = new EtwProfiler(CreateDefaultConfig());
@@ -44,11 +44,11 @@ public class ConcurrencyVisualizerProfiler : IProfiler
 
         public string ShortName => "CV";
 
-        public IEnumerable<string> Ids => new[] { nameof(ConcurrencyVisualizerProfiler) };
+        public IEnumerable<string> Ids => [nameof(ConcurrencyVisualizerProfiler)];
 
-        public IEnumerable<IExporter> Exporters => Array.Empty<IExporter>();
+        public IEnumerable<IExporter> Exporters => [];
 
-        public IEnumerable<IAnalyser> Analysers => Array.Empty<IAnalyser>();
+        public IEnumerable<IAnalyser> Analysers => [];
 
         public void DisplayResults(ILogger logger)
         {