Merged
Conversation
There was a breaking change between 2.27 and 2.28 - MongoDB.Driver added an assembly strong name. We can now remove our NoWarn workarounds for MongoDB. Except Aspire.MongoDB.Driver still needs the NoWarn for 2 the health check and DiagnosticSource packages.
Member
Author
|
/backport to release/8.2 |
Contributor
|
Started backporting to release/8.2: https://github.com/dotnet/aspire/actions/runs/10604786056 |
This was referenced Aug 28, 2024
sebastienros
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was a breaking change between 2.27 and 2.28 - MongoDB.Driver added an assembly strong name.
We can now remove our NoWarn workarounds for MongoDB. Except Aspire.MongoDB.Driver still needs the NoWarn for 2 the health check and DiagnosticSource packages.
Fixes #5427
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow