-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Incorrect CustomValidationAttribute remarks #3126
Copy link
Copy link
Open
Labels
Pri3Indicates issues/PRs that are low priorityIndicates issues/PRs that are low priorityarea-System.ComponentModel.DataAnnotationscross-platformIndicates issues or PRs that relate to content applicable to both Framework and Core.Indicates issues or PRs that relate to content applicable to both Framework and Core.waiting-on-feedbackIndicates PRs that are waiting for feedback from SMEs before they can be mergedIndicates PRs that are waiting for feedback from SMEs before they can be merged
Description
Metadata
Metadata
Assignees
Labels
Pri3Indicates issues/PRs that are low priorityIndicates issues/PRs that are low priorityarea-System.ComponentModel.DataAnnotationscross-platformIndicates issues or PRs that relate to content applicable to both Framework and Core.Indicates issues or PRs that relate to content applicable to both Framework and Core.waiting-on-feedbackIndicates PRs that are waiting for feedback from SMEs before they can be mergedIndicates PRs that are waiting for feedback from SMEs before they can be merged
Type
Fields
Give feedbackNo fields configured for issues without a type.
Content: https://docs.microsoft.com/en-us/dotnet/api/system.componentmodel.dataannotations.customvalidationattribute.method?view=netcore-2.2
Content source: xml/System.ComponentModel.DataAnnotations/CustomValidationAttribute.xml
The remarks for the
Methodproperty ofCustomValidationAttributeincorrectly state that the specified method must return aBooleanand takes aValidationResultoutparam. In .Net Core 2.2 at least, it must return aValidationResult.Maybe the signature is different in different languages?
Additionally, it would be preferable to have the valid signatures listed as code snippets rather than described in text.