build: fall back to local KubeOps CLI#1020
Conversation
31f5770 to
132540f
Compare
|
Rebased |
|
Heads up: the GitHub Actions check suites for this PR are in an "action required" state (workflows from forks need maintainer approval), so CI hasn't actually run yet. Could a maintainer please approve and run the workflows for this PR? (The branch is rebased onto the latest Local sanity checks:
|
|
@fuguiKz thanks for the heads up - I've triggered the workflows to run but I still see some points from the review pending. I appreciate your work - if there are some points unclear please let me know. I think it would absolutely make sense to make all samples use the local installation when we state that it is recommended - instead of stating it is recommended and make all samples use the global installation. thanks 😄 |
132540f to
cc6d3a1
Compare
|
Rebased this PR branch onto the latest |
Fixes #1009
Problem
KubeOps.Clias a local tool, but local tools are not onPATH, so invokingkubeopsduring the build can fail.Changes
src/KubeOps.Operator/Build/KubeOps.Operator.targets: when the defaultkubeopscommand is not available andKubeOpsCliwas not overridden, fall back todotnet tool run kubeops(and run CLI commands from the project directory).dotnet tool run kubeops(build-customization.mdx,cli.mdx,getting-started.mdx).Verification
dotnet build src/KubeOps.Operator/KubeOps.Operator.csproj -c Release