Commit 3768e58
committed
Remove Assert in Method.MakeGeneric on Invalid Arg
The call to mono_class_inflate_generic_method_checked will set error
when there are invalid types (e.g. typeof(void)/typeof(int*)) passed in.
This should not be an assert, it should fall to the "Invalid generic
arguments" message below. This does lose the error returned by
mono_class_inflate_generic_method_checked but that error isn't user
friendly. It would report be something like: "MVAR 1 cannot be expanded
with type 0x1" Instead report the more readable error to the user.
Fix: 713391 parent 64e178b commit 3768e58
3 files changed
Lines changed: 3 additions & 2 deletions
File tree
- src/mono
- mono/metadata
- out/build/x64-Debug
- .cmake/api/v1/query/client-MicrosoftVS
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2728 | 2728 | | |
2729 | 2729 | | |
2730 | 2730 | | |
2731 | | - | |
2732 | 2731 | | |
2733 | | - | |
| 2732 | + | |
2734 | 2733 | | |
2735 | 2734 | | |
2736 | 2735 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
0 commit comments