Commit a348be8
Filter out SPMI metric diffs smaller than ±0.001% (#125684)
## Description
SPMI metric diff reporting shows noise as changes even when there are no
actual code diffs. The `write_metricdiff_markdown_summary` function used
a bare `!=` equality check, so any tiny numeric variance was reported as
significant.
Inlined an `abs(compute_pct(...)) >= 0.01` threshold check directly in
the list comprehension filter in `superpmi.py` to suppress metric diffs
below ±0.01%. This is consistent with the existing `is_significant_pct`
threshold pattern already used in `write_tpdiff_markdown_summary`.
A dummy comment change was also added to `src/coreclr/jit/compiler.cpp`
to trigger the SPMI pipeline and validate the fix.
<!-- START COPILOT ORIGINAL PROMPT -->
<details>
<summary>Original prompt</summary>
>
> ----
>
> *This section details on the original issue you should resolve*
>
> <issue_title>JIT: Metrics show changes even with no-diff
changes</issue_title>
> <issue_description>E.g.
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1339686&view=ms.vss-build-web.run-extensions-tab
has no diffs, yet several metrics show up as changing. We probably
should increase the expected variance of these metrics so that they
don't show up unless they are actually changing.
>
> cc @EgorBo </issue_description>
>
> <agent_instructions>Please do not report diffs for SPMI metric diffs
if the difference is smaller than +/- 0.01%</agent_instructions>
>
> ## Comments on the Issue (you are @copilot in this section)
>
> <comments>
> </comments>
>
</details>
<!-- START COPILOT CODING AGENT SUFFIX -->
- Fixes #125683
<!-- START COPILOT CODING AGENT TIPS -->
---
💬 Send tasks to Copilot coding agent from
[Slack](https://gh.io/cca-slack-docs) and
[Teams](https://gh.io/cca-teams-docs) to turn conversations into code.
Copilot posts an update in your thread when it's finished.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
Co-authored-by: Egor Bogatov <egorbo@gmail.com>1 parent 34dd74d commit a348be8
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3564 | 3564 | | |
3565 | 3565 | | |
3566 | 3566 | | |
3567 | | - | |
| 3567 | + | |
3568 | 3568 | | |
3569 | 3569 | | |
3570 | 3570 | | |
| |||
0 commit comments