Skip to content

Commit cb5a903

Browse files
authored
Apply suggestions from code review
1 parent 7983b9f commit cb5a903

6 files changed

Lines changed: 18 additions & 18 deletions

File tree

src/coreclr/vm/arm/asmconstants.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,10 @@ ASMCONSTANTS_C_ASSERT(SIZEOF__MethodTable == sizeof(MethodTable));
8282
ASMCONSTANTS_C_ASSERT(SIZEOF__Frame == sizeof(Frame));
8383

8484
#define SIZEOF__CONTEXT 0x1a0
85-
ASMCONSTANTS_C_ASSERT(SIZEOF__CONTEXT == sizeof(CONTEXT));
85+
ASMCONSTANTS_C_ASSERT(SIZEOF__CONTEXT == sizeof(T_CONTEXT));
8686

8787
#define OFFSETOF__CONTEXT__R4 0x14
88-
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__R4 == offsetof(CONTEXT, R4));
88+
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__R4 == offsetof(T_CONTEXT, R4));
8989

9090
#define SIZEOF__CalleeSavedRegisters 0x24
9191
ASMCONSTANTS_C_ASSERT(SIZEOF__CalleeSavedRegisters == sizeof(CalleeSavedRegisters))

src/coreclr/vm/arm64/asmconstants.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,13 @@ ASMCONSTANTS_C_ASSERT(SIZEOF__Frame == sizeof(Frame));
9999
#else
100100
#define SIZEOF__CONTEXT 0x390
101101
#endif
102-
ASMCONSTANTS_C_ASSERT(SIZEOF__CONTEXT == sizeof(CONTEXT));
102+
ASMCONSTANTS_C_ASSERT(SIZEOF__CONTEXT == sizeof(T_CONTEXT));
103103

104104
#define OFFSETOF__CONTEXT__X19 0xA0
105-
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__X19 == offsetof(CONTEXT, X19));
105+
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__X19 == offsetof(T_CONTEXT, X19));
106106

107107
#define OFFSETOF__CONTEXT__Fp 0xF0
108-
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__Fp == offsetof(CONTEXT, Fp));
108+
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__Fp == offsetof(T_CONTEXT, Fp));
109109

110110
#define OFFSETOF__DynamicHelperStubArgs__Constant1 0x0
111111
ASMCONSTANTS_C_ASSERT(OFFSETOF__DynamicHelperStubArgs__Constant1

src/coreclr/vm/loongarch64/asmconstants.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,13 @@ ASMCONSTANTS_C_ASSERT(VASigCookie__pNDirectILStub == offsetof(VASigCookie, pNDir
9797
ASMCONSTANTS_C_ASSERT(SIZEOF__Frame == sizeof(Frame));
9898

9999
#define SIZEOF__CONTEXT 0x520
100-
ASMCONSTANTS_C_ASSERT(SIZEOF__CONTEXT == sizeof(CONTEXT));
100+
ASMCONSTANTS_C_ASSERT(SIZEOF__CONTEXT == sizeof(T_CONTEXT));
101101

102102
#define OFFSETOF__CONTEXT__S0 0xC0
103-
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__S0 == offsetof(CONTEXT, S0));
103+
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__S0 == offsetof(T_CONTEXT, S0));
104104

105105
#define OFFSETOF__CONTEXT__Fp 0xB8
106-
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__Fp == offsetof(CONTEXT, Fp));
106+
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__Fp == offsetof(T_CONTEXT, Fp));
107107

108108
//=========================================
109109
#define OFFSETOF__MethodTable__m_dwFlags 0x0

src/coreclr/vm/loongarch64/asmhelpers.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -741,7 +741,7 @@ NESTED_ENTRY CallEHFunclet, _TEXT, NoHandler
741741
// Save the SP of this function
742742
st.d $sp, $a3, 0
743743

744-
ld.d $fp, $a2, OFFSETOF__CONTEXT__FP
744+
ld.d $fp, $a2, OFFSETOF__CONTEXT__Fp
745745
ld.d $s0, $a2, OFFSETOF__CONTEXT__S0
746746
ld.d $s1, $a2, OFFSETOF__CONTEXT__S0+8
747747
ld.d $s2, $a2, OFFSETOF__CONTEXT__S0+16

src/coreclr/vm/riscv64/asmconstants.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,22 +92,22 @@ ASMCONSTANTS_C_ASSERT(VASigCookie__pNDirectILStub == offsetof(VASigCookie, pNDir
9292
ASMCONSTANTS_C_ASSERT(SIZEOF__Frame == sizeof(Frame));
9393

9494
#define SIZEOF__CONTEXT 0x220
95-
ASMCONSTANTS_C_ASSERT(SIZEOF__CONTEXT == sizeof(CONTEXT));
95+
ASMCONSTANTS_C_ASSERT(SIZEOF__CONTEXT == sizeof(T_CONTEXT));
9696

9797
#define OFFSETOF__CONTEXT__Gp 0x20
98-
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__Gp == offsetof(CONTEXT, Gp));
98+
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__Gp == offsetof(T_CONTEXT, Gp));
9999

100100
#define OFFSETOF__CONTEXT__Tp 0x28
101-
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__Tp == offsetof(CONTEXT, Tp));
101+
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__Tp == offsetof(T_CONTEXT, Tp));
102102

103103
#define OFFSETOF__CONTEXT__Fp 0x48
104-
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__Fp == offsetof(CONTEXT, Fp));
104+
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__Fp == offsetof(T_CONTEXT, Fp));
105105

106106
#define OFFSETOF__CONTEXT__S1 0x50
107-
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__S1 == offsetof(CONTEXT, S1));
107+
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__S1 == offsetof(T_CONTEXT, S1));
108108

109109
#define OFFSETOF__CONTEXT__S2 0x98
110-
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__S2 == offsetof(CONTEXT, S2));
110+
ASMCONSTANTS_C_ASSERT(OFFSETOF__CONTEXT__S2 == offsetof(T_CONTEXT, S2));
111111

112112
//=========================================
113113
#define OFFSETOF__MethodTable__m_dwFlags 0x0

src/coreclr/vm/riscv64/asmhelpers.S

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -586,9 +586,9 @@ NESTED_ENTRY CallEHFunclet, _TEXT, NoHandler
586586
// Save the SP of this function
587587
sd sp, 0(a3)
588588

589-
ld gp, OFFSETOF__CONTEXT__GP(a2)
590-
ld tp, OFFSETOF__CONTEXT__TP(a2)
591-
ld fp, OFFSETOF__CONTEXT__FP(a2)
589+
ld gp, OFFSETOF__CONTEXT__Gp(a2)
590+
ld tp, OFFSETOF__CONTEXT__Tp(a2)
591+
ld fp, OFFSETOF__CONTEXT__Fp(a2)
592592
ld s1, OFFSETOF__CONTEXT__S1(a2)
593593
ld s2, OFFSETOF__CONTEXT__S2(a2)
594594
ld s3, OFFSETOF__CONTEXT__S2+8(a2)

0 commit comments

Comments
 (0)