fix(deps): update kafka-client.version to v4 (release/5.0.x) (major) (#555)

* fix(deps): update kafka-client.version to v4

* chore(deps): update dependency org.springframework.kafka:spring-kafka-test to v4

* Migrate tests to JUnit Jupiter

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jochen Schalanda <jochen@schalanda.name>

Author: renovate[bot]

pom.xml

@@ -26,8 +26,8 @@
     <sonar.projectKey>dropwizard_dropwizard-kafka</sonar.projectKey>
 
     <brave.version>6.3.0</brave.version>
-    <kafka-client.version>3.9.1</kafka-client.version>
-    <spring-kafka.version>3.3.11</spring-kafka.version>
+    <kafka-client.version>4.1.1</kafka-client.version>
+    <spring-kafka.version>4.0.1</spring-kafka.version>
   </properties>
 
   <dependencyManagement>
@@ -126,15 +126,19 @@
 
     <!-- test dependencies -->
     <dependency>
-      <groupId>org.junit.vintage</groupId>
-      <artifactId>junit-vintage-engine</artifactId>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter</artifactId>
       <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>org.mockito</groupId>
       <artifactId>mockito-core</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.awaitility</groupId>
+      <artifactId>awaitility</artifactId>
+    </dependency>
     <dependency>
       <groupId>io.dropwizard</groupId>
       <artifactId>dropwizard-testing</artifactId>

src/test/java/io/dropwizard/kafka/BasicKafkaAdminClientFactoryTest.java

@@ -10,7 +10,7 @@
 import io.dropwizard.jersey.validation.Validators;
 import io.dropwizard.lifecycle.setup.LifecycleEnvironment;
 import org.apache.kafka.clients.admin.AdminClient;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.io.File;
 import java.util.Collections;

src/test/java/io/dropwizard/kafka/BasicKafkaConsumerFactoryTest.java

@@ -10,7 +10,7 @@
 import io.dropwizard.jersey.validation.Validators;
 import io.dropwizard.lifecycle.setup.LifecycleEnvironment;
 import org.apache.kafka.clients.consumer.Consumer;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.io.File;
 

src/test/java/io/dropwizard/kafka/BasicKafkaProducerFactoryTest.java

@@ -11,7 +11,7 @@
 import io.dropwizard.jersey.validation.Validators;
 import io.dropwizard.lifecycle.setup.LifecycleEnvironment;
 import org.apache.kafka.clients.producer.Producer;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.io.File;
 

src/test/java/io/dropwizard/kafka/DropwizardKafkaUtilsTest.java

@@ -1,10 +1,13 @@
 package io.dropwizard.kafka;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
 
 import java.util.ArrayList;
 import java.util.Map;
 
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
 public class DropwizardKafkaUtilsTest {
     @Test
     public void actualSubclassShouldBeCorrectlyValidated() {
@@ -13,17 +16,17 @@ public void actualSubclassShouldBeCorrectlyValidated() {
         DropwizardKafkaUtils.validateStringIsValidSubClass(integerClassName, Object.class);
     }
 
-    @Test(expected = IllegalStateException.class)
+    @Test
     public void nonSubclassShouldFailValidations() {
         final String arrayListClassName = ArrayList.class.getName();
 
-        DropwizardKafkaUtils.validateStringIsValidSubClass(arrayListClassName, Map.class);
+        assertThrows(IllegalStateException.class, () -> DropwizardKafkaUtils.validateStringIsValidSubClass(arrayListClassName, Map.class));
     }
 
-    @Test(expected = RuntimeException.class)
+    @Test
     public void classThatDoesNotExistShouldFailValidations() {
         final String fakeClassName = "blah.blah.blah.businesslogic.ObjectFactoryFactoryVisitor";
 
-        DropwizardKafkaUtils.validateStringIsValidSubClass(fakeClassName, Object.class);
+        assertThrows(RuntimeException.class, () -> DropwizardKafkaUtils.validateStringIsValidSubClass(fakeClassName, Object.class));
     }
 }

src/test/java/io/dropwizard/kafka/KafkaTopicFactoryTest.java

@@ -7,7 +7,7 @@
 import io.dropwizard.jersey.validation.Validators;
 import org.apache.kafka.clients.admin.NewTopic;
 import org.apache.kafka.common.config.TopicConfig;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import jakarta.validation.Validator;
 import java.io.File;

src/test/java/io/dropwizard/kafka/MockKafkaConsumerFactoryTest.java

@@ -1,7 +1,7 @@
 package io.dropwizard.kafka;
 
 import io.dropwizard.jackson.DiscoverableSubtypeResolver;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import static org.assertj.core.api.Assertions.assertThat;
 

src/test/java/io/dropwizard/kafka/MockKafkaProducerFactoryTest.java

@@ -1,7 +1,7 @@
 package io.dropwizard.kafka;
 
 import io.dropwizard.jackson.DiscoverableSubtypeResolver;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import static org.assertj.core.api.Assertions.assertThat;
 

src/test/java/io/dropwizard/kafka/deserializer/ByteArrayDeserializerFactoryTest.java

@@ -8,7 +8,7 @@
 import io.dropwizard.jersey.validation.Validators;
 import org.apache.kafka.clients.consumer.ConsumerConfig;
 import org.apache.kafka.common.serialization.ByteArrayDeserializer;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.io.File;
 import java.util.Map;

src/test/java/io/dropwizard/kafka/deserializer/ByteBufferDeserializerFactoryTest.java

@@ -8,7 +8,7 @@
 import io.dropwizard.jersey.validation.Validators;
 import org.apache.kafka.clients.consumer.ConsumerConfig;
 import org.apache.kafka.common.serialization.ByteBufferDeserializer;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.io.File;
 import java.util.Map;