Skip to content

Commit c4ae873

Browse files
committed
Improve readability integration test
The new edition changed the formatting, which needed some adjustment to have the same readability.
1 parent 3e8c22f commit c4ae873

1 file changed

Lines changed: 19 additions & 54 deletions

File tree

src/test_integration/mod.rs

Lines changed: 19 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ mod tests {
77
use std::path::Path;
88
use std::process::{Command, Stdio};
99

10-
static VAULT_INTEGRATION_TEST_DIR: &str = "vault_integration_test";
10+
static TEST_DIR: &str = "vault_integration_test";
1111

1212
fn cmd(
1313
dir: impl AsRef<Path>,
@@ -47,38 +47,16 @@ mod tests {
4747
fn test_prepare() {
4848
cmd(".", "cargo", &["build"], false);
4949

50-
cmd(".", "rm", &["-rf", VAULT_INTEGRATION_TEST_DIR], false);
51-
cmd(".", "mkdir", &["-p", VAULT_INTEGRATION_TEST_DIR], false);
50+
cmd(".", "rm", &["-rf", TEST_DIR], false);
51+
cmd(".", "mkdir", &["-p", TEST_DIR], false);
5252

53-
cmd(
54-
".",
55-
"cp",
56-
&[
57-
"./target/debug/vault",
58-
&format!("{}/vault", VAULT_INTEGRATION_TEST_DIR),
59-
],
60-
false,
61-
);
62-
cmd(
63-
".",
64-
"cp",
65-
&["-r", "./fixtures", VAULT_INTEGRATION_TEST_DIR],
66-
false,
67-
);
68-
cmd(
69-
VAULT_INTEGRATION_TEST_DIR,
70-
"mv",
71-
&["./fixtures", ".vault"],
72-
false,
73-
);
53+
let vault_dir = &format!("{}/vault", TEST_DIR);
54+
cmd(".", "cp", &["./target/debug/vault", vault_dir], false);
55+
cmd(".", "cp", &["-r", "./fixtures", TEST_DIR], false);
56+
cmd(TEST_DIR, "mv", &["./fixtures", ".vault"], false);
7457

75-
cmd(VAULT_INTEGRATION_TEST_DIR, "ls", &["-lah"], false);
76-
cmd(
77-
VAULT_INTEGRATION_TEST_DIR,
78-
"ls",
79-
&["-lah", "./.vault"],
80-
false,
81-
);
58+
cmd(TEST_DIR, "ls", &["-lah"], false);
59+
cmd(TEST_DIR, "ls", &["-lah", "./.vault"], false);
8260
}
8361

8462
#[test]
@@ -92,12 +70,7 @@ mod tests {
9270

9371
for valid_secret in &valid_secrets {
9472
println!("checking {}", valid_secret);
95-
let content = cmd(
96-
VAULT_INTEGRATION_TEST_DIR,
97-
"./vault",
98-
&["get", valid_secret],
99-
true,
100-
);
73+
let content = cmd(TEST_DIR, "./vault", &["get", valid_secret], true);
10174
assert_eq!(format!("{}_CONTENT", valid_secret).into_bytes(), content);
10275
}
10376

@@ -114,16 +87,13 @@ mod tests {
11487
.collect::<Vec<_>>()
11588
.join(",");
11689

117-
let mut file = File::create(format!(
118-
"{}/example_template.vault",
119-
VAULT_INTEGRATION_TEST_DIR
120-
))
121-
.expect("could not create template");
90+
let mut file = File::create(format!("{}/example_template.vault", TEST_DIR))
91+
.expect("could not create template");
12292
file.write_all(template.as_bytes())
12393
.expect("could not write template");
12494

12595
let template_output = cmd(
126-
VAULT_INTEGRATION_TEST_DIR,
96+
TEST_DIR,
12797
"./vault",
12898
&["template", "example_template.vault"],
12999
true,
@@ -137,7 +107,7 @@ mod tests {
137107
assert_eq!(
138108
"VERSION_1_0_0_SECRET_CONTENT",
139109
String::from_utf8_lossy(&cmd(
140-
VAULT_INTEGRATION_TEST_DIR,
110+
TEST_DIR,
141111
"./vault",
142112
&["get", "VERSION_1_0_0_SECRET"],
143113
true
@@ -151,7 +121,7 @@ mod tests {
151121
test_prepare();
152122

153123
let content = cmd(
154-
VAULT_INTEGRATION_TEST_DIR,
124+
TEST_DIR,
155125
"./vault",
156126
&[
157127
"get_multi",
@@ -171,7 +141,7 @@ mod tests {
171141
fn test_integration_rotate_key_and_decode_content() {
172142
test_prepare();
173143

174-
let content = cmd(VAULT_INTEGRATION_TEST_DIR, "./vault", &["rotate"], true);
144+
let content = cmd(TEST_DIR, "./vault", &["rotate"], true);
175145
println!("output: {}", String::from_utf8_lossy(&content));
176146

177147
// delete backup files
@@ -195,22 +165,17 @@ mod tests {
195165
#[serial]
196166
fn test_integration_rotate_key_and_read_old_file() {
197167
test_prepare();
198-
cmd(VAULT_INTEGRATION_TEST_DIR, "./vault", &["rotate"], true);
168+
cmd(TEST_DIR, "./vault", &["rotate"], true);
199169

200-
cmd(
201-
VAULT_INTEGRATION_TEST_DIR,
202-
"rm",
203-
&["-rf", "./.vault/secrets"],
204-
false,
205-
);
170+
cmd(TEST_DIR, "rm", &["-rf", "./.vault/secrets"], false);
206171

207172
cmd(
208173
".",
209174
"cp",
210175
&[
211176
"-r",
212177
"./fixtures/secrets",
213-
&format!("{}/.vault/secrets", VAULT_INTEGRATION_TEST_DIR),
178+
&format!("{}/.vault/secrets", TEST_DIR),
214179
],
215180
false,
216181
);

0 commit comments

Comments
 (0)