Skip to content

[e2e] - Add source maps. Fixes #14298#14299

Merged
rhopp merged 1 commit into
eclipse-che:masterfrom
rhopp:sourceMaps
Aug 23, 2019
Merged

[e2e] - Add source maps. Fixes #14298#14299
rhopp merged 1 commit into
eclipse-che:masterfrom
rhopp:sourceMaps

Conversation

@rhopp

@rhopp rhopp commented Aug 21, 2019

Copy link
Copy Markdown
Contributor

Signed-off-by: Radim Hopp rhopp@redhat.com

What does this PR do?

Result:
image

What issues does this PR fix or reference?

Fixes #14298

@rhopp
[e2e] - Add source maps. Fixes eclipse-che#14298
5b413d2 
Signed-off-by: Radim Hopp <rhopp@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Aug 21, 2019
@che-bot

che-bot commented Aug 21, 2019

Copy link
Copy Markdown
Contributor

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14299

@dmytro-ndp

dmytro-ndp commented Aug 21, 2019

Copy link
Copy Markdown
Contributor

@rhopp : there should be a test failure to check changes.

@che-bot

che-bot commented Aug 21, 2019

Copy link
Copy Markdown
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14299
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp

dmytro-ndp commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

I am curious if it works with HappyPath.spec.ts. It would be extremely useful to locate the exact step of test which failed.

@rhopp

rhopp commented Aug 23, 2019

Copy link
Copy Markdown
Contributor Author

Unfortunately because of async nature, the stacktrace is sometimes incomplete. I've tried to use --async-stack-traces, but it didn't work for me.

As I don't have any idea how to improve this, I'll merge this PR, as it also provides some value in the current state...

@rhopp rhopp merged commit 789a33b into eclipse-che:master Aug 23, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 23, 2019
@che-bot che-bot added this to the 7.1.0 milestone Aug 23, 2019
@SDAdham SDAdham mentioned this pull request Aug 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

No one assigned

Labels

kind/enhancement A feature request - must adhere to the feature request template.

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

Add source maps to Happy Path tests execution

4 participants

@rhopp @che-bot @dmytro-ndp @Ohrimenko1988