refactor: remove unused code#14480
Merged
Merged
Conversation
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
vitaliy-guliy
requested review from
AndrienkoAleksandr,
akurinnoy,
benoitf,
evidolob,
mmorhun and
olexii4
vitaliy-guliy
requested review from
ashumilova,
l0rd,
nickboldt and
rhopp
as code owners
che-bot
added
status/code-review
benoitf
approved these changes
Sep 9, 2019
Contributor
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Contributor
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
Contributor
Author
|
@dmytro-ndp could you please check what has failed? |
akurinnoy
approved these changes
Sep 14, 2019
mmorhun
approved these changes
Sep 16, 2019
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Contributor
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Contributor
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
AndrienkoAleksandr
approved these changes
Sep 27, 2019
Contributor
|
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2447//Selenium_20tests_20report/) doesn't show any regression against this Pull request. |
Contributor
Author
|
@SkorikSergey thanks! |
che-bot
removed
the
status/code-review
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com
What does this PR do?
Removes unused code from the Dashboard
What issues does this PR fix or reference?
Unused code was removed when investigating #14110