splitAttributes keeps first attribute on same line#161
Merged
NikolasKomonen merged 1 commit intoOct 12, 2018
Conversation
|
@NikolasKomonen thanks for fixing this issue so quickly! I just have one question about the PR. I noticed in the test |
Contributor
Author
|
@alessandrodimarco sure, I just wasn't sure what people preferred so this will be fine. |
Fixes redhat-developer/vscode-xml#59 Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen
force-pushed
the
splitAttributesFix
branch
from
331ad39 to
929b17d
Compare
Contributor
|
@NikolasKomonen can I merge it? |
Contributor
Author
|
@angelozerr yup, ill do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #redhat-developer/vscode-xml#59