Skip to content

Commit 8ad85c2

Browse files
committed
prevent accidental mutation of default early boot lists
1 parent 86d2eb9 commit 8ad85c2

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

packages/ember-auto-import/ts/webpack.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,27 +46,27 @@ const debug = makeDebug('ember-auto-import:webpack');
4646
* without the need for this code to be updated)
4747
*
4848
*/
49-
const DEFAULT_EARLY_BOOT_SET = [
49+
const DEFAULT_EARLY_BOOT_SET = Object.freeze([
5050
'@glimmer/tracking',
5151
'@glimmer/component',
5252
'@ember/service',
5353
'@ember/controller',
5454
'@ember/routing/route',
5555
'@ember/component',
56-
];
56+
]);
5757

5858
/**
5959
* @glimmer/tracking + @glimmer/component
6060
* are separate addons, yet included in ember-source (for now),
6161
* but we will be required to use the real glimmer packages before
6262
* ember-source is converted to v2 (else we implement more hacks at resolver time!)
6363
*/
64-
const BOOT_SET_FROM_EMBER_SOURCE = [
64+
const BOOT_SET_FROM_EMBER_SOURCE = Object.freeze([
6565
'@ember/service',
6666
'@ember/controller',
6767
'@ember/routing/route',
6868
'@ember/component',
69-
];
69+
]);
7070

7171
registerHelper('js-string-escape', jsStringEscape);
7272
registerHelper('join', function (list, connector) {
@@ -434,7 +434,7 @@ export default class WebpackBundler extends Plugin implements Bundler {
434434

435435
private getEarlyBootSet() {
436436
let result = this.opts.earlyBootSet
437-
? this.opts.earlyBootSet(DEFAULT_EARLY_BOOT_SET)
437+
? this.opts.earlyBootSet([...DEFAULT_EARLY_BOOT_SET])
438438
: DEFAULT_EARLY_BOOT_SET;
439439

440440
if (!Array.isArray(result)) {
@@ -489,7 +489,7 @@ export default class WebpackBundler extends Plugin implements Bundler {
489489
}
490490

491491
private writeEntryFile(name: string, deps: BundleDependencies) {
492-
let v1EmberDeps: string[] = this.getEarlyBootSet();
492+
let v1EmberDeps = this.getEarlyBootSet();
493493

494494
writeFileSync(
495495
join(this.stagingDir, `${name}.cjs`),

0 commit comments

Comments
 (0)