Skip to content

Commit 42cefe4

Browse files
committed
Update Elastic.Elasticsearch.Xunit to 0.11.0 and restore GitHubActionsTestLogger
0.11.0 fixes the double test execution that caused GitHubActionsTestLogger to crash with duplicate test case IDs. Restore the logger and --logger arg now that the root cause is fixed.
1 parent 7409edd commit 42cefe4

4 files changed

Lines changed: 11 additions & 2 deletions

File tree

build/scripts/Targets.fs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,10 @@ let private runTests (arguments: ParseResults<Arguments>) testMode =
6464
| Unit -> [ "--filter"; "FullyQualifiedName!~IntegrationTests" ]
6565
| Integration -> [ "--filter"; "FullyQualifiedName~IntegrationTests" ]
6666

67+
let loggerArg = $"--logger:GitHubActions"
6768
let settingsArg = if runningOnCI then ["-s"; ".ci.runsettings"] else [];
6869

69-
execWithTimeout "dotnet" ([ "test" ] @ filterArg @ settingsArg @ [ "-c"; "RELEASE"; "-m:1" ]) (Nullable(TimeSpan.FromMinutes 15.))
70+
execWithTimeout "dotnet" ([ "test" ] @ filterArg @ settingsArg @ [ "-c"; "RELEASE"; "-m:1"; loggerArg ]) (Nullable(TimeSpan.FromMinutes 15.))
7071
|> ignore
7172

7273
let private test (arguments: ParseResults<Arguments>) =

tests-integration/Directory.Build.props

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,9 @@
2121
<PrivateAssets>all</PrivateAssets>
2222
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2323
</PackageReference>
24+
<PackageReference Include="GitHubActionsTestLogger" Version="3.0.1">
25+
<PrivateAssets>all</PrivateAssets>
26+
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
27+
</PackageReference>
2428
</ItemGroup>
2529
</Project>

tests-integration/Elasticsearch.IntegrationDefaults/Elasticsearch.IntegrationDefaults.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
<ItemGroup>
1212
<PackageReference Include="Elastic.Clients.Elasticsearch" Version="9.2.1" />
13-
<PackageReference Include="Elastic.Elasticsearch.Xunit" Version="0.10.0" />
13+
<PackageReference Include="Elastic.Elasticsearch.Xunit" Version="0.11.0" />
1414
<PackageReference Include="Elastic.Ingest.Elasticsearch" Version="0.17.1" />
1515

1616
</ItemGroup>

tests/Directory.Build.props

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,9 @@
2121
<PrivateAssets>all</PrivateAssets>
2222
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2323
</PackageReference>
24+
<PackageReference Include="GitHubActionsTestLogger" Version="3.0.1">
25+
<PrivateAssets>all</PrivateAssets>
26+
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
27+
</PackageReference>
2428
</ItemGroup>
2529
</Project>

0 commit comments

Comments
 (0)