fix(electron-builder): Configuring yargs through package.json is deprecated #3751

1. remove `yargs` field from `package.json`.
2. upgrade `@types/yargs` for better type definitions.
3. move `parserConfiguration` to the entry point for every "bin".

Close #3751

Author: firede

packages/electron-builder/package.json

@@ -63,8 +63,5 @@
   "typings": "./out/index.d.ts",
   "publishConfig": {
     "tag": "next"
-  },
-  "yargs": {
-    "camel-case-expansion": false
   }
 }

packages/electron-builder/src/builder.ts

@@ -235,11 +235,7 @@ export function build(rawOptions?: CliOptions): Promise<Array<string>> {
 export function configureBuildCommand(yargs: yargs.Argv): yargs.Argv {
   const publishGroup = "Publishing:"
   const buildGroup = "Building:"
-  const deprecated = "Deprecated:";
-
-  (yargs as any).parserConfiguration({
-    "camel-case-expansion": false,
-  })
+  const deprecated = "Deprecated:"
 
   return yargs
     .option("mac", {

packages/electron-builder/src/cli/cli.ts

@@ -17,6 +17,9 @@ import { start } from "./start"
 
 // tslint:disable:no-unused-expression
 yargs
+  .parserConfiguration({
+    "camel-case-expansion": false,
+  })
   .command(["build", "*"], "Build", configureBuildCommand, wrap(build))
   .command("install-app-deps", "Install app deps", configureInstallAppDepsCommand, wrap(installAppDeps))
   .command("node-gyp-rebuild", "Rebuild own native code", configureInstallAppDepsCommand /* yes, args the same as for install app deps */, wrap(rebuildAppNativeCode))

packages/electron-builder/src/cli/install-app-deps.ts

@@ -19,6 +19,9 @@ export function configureInstallAppDepsCommand(yargs: yargs.Argv): yargs.Argv {
   // https://github.com/yargs/yargs/issues/760
   // demandOption is required to be set
   return yargs
+    .parserConfiguration({
+      "camel-case-expansion": false,
+    })
     .option("platform", {
       choices: ["linux", "darwin", "win32"],
       default: process.platform,

test/src/BuildTest.ts

@@ -12,6 +12,7 @@ test("cli", async () => {
   // because these methods are internal
   const { configureBuildCommand, normalizeOptions } = require("electron-builder/out/builder")
   const yargs = require("yargs")
+  yargs.parserConfiguration({"camel-case-expansion": false})
   configureBuildCommand(yargs)
 
   function parse(input: string): any {