Skip to content

Move crypto migration#8666

Merged
bmarty merged 5 commits into
element-hq:developfrom
yostyle:yostyle/fix_crypto_migration
Dec 21, 2023
Merged

Move crypto migration#8666
bmarty merged 5 commits into
element-hq:developfrom
yostyle:yostyle/fix_crypto_migration

Conversation

@yostyle
Copy link
Copy Markdown
Contributor

@yostyle yostyle commented Oct 13, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Move crypto rust migration in the right place.

Motivation and context

Keys migration from kotlin to rust crypto does not work when an account has a single session and no backup.
@BillCarsonFr is aware about this problem

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle marked this pull request as ready for review October 13, 2023 15:51
@yostyle
Copy link
Copy Markdown
Contributor Author

yostyle commented Oct 23, 2023

Signed-off-by: yostyle y.pintas@gmail.com

@bmarty bmarty requested a review from BillCarsonFr November 7, 2023 13:13
Copy link
Copy Markdown
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostyle yostyle force-pushed the yostyle/fix_crypto_migration branch from 9fa2061 to 31d3b9d Compare November 16, 2023 15:45
@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Dec 21, 2023
@bmarty bmarty merged commit e818f86 into element-hq:develop Dec 21, 2023
@yostyle
Copy link
Copy Markdown
Contributor Author

yostyle commented Dec 21, 2023

Thanks @bmarty @BillCarsonFr

@yostyle yostyle deleted the yostyle/fix_crypto_migration branch December 21, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-NextRelease For issues and PRs which should be included in the NextRelease.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants