UTD posthog reporting add more properties to captured event#8780
Merged
Conversation
Closed
3 tasks
b88bc98 to
4d04b27
Compare
bmarty
reviewed
Mar 28, 2024
Member
bmarty
left a comment
There was a problem hiding this comment.
Thanks, one problem to fix, else it's all good to me.
| // now remove from tracked | ||
| trackedEventsMap.remove(decryptionFailure.failedEventId) | ||
| // mark as already reported | ||
| alreadyReported.add(decryptionFailure.failedEventId) |
Member
There was a problem hiding this comment.
alreadyReported does not seem to be read.
It was used to filter the Events previously (line 140 in previous version)
Member
Author
There was a problem hiding this comment.
Oh good catch. I fixed the unit test that was not correctly testing that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8779
Refactored the DecryptionFailureTracker so that it can report late decryption and permanent decryptions errors.
Type of change
Content
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist