Skip to content

Remove unused WebRTC dependency#8658

Merged
yostyle merged 2 commits into
developfrom
yostyle/clean_jitsi_deps
Nov 7, 2023
Merged

Remove unused WebRTC dependency#8658
yostyle merged 2 commits into
developfrom
yostyle/clean_jitsi_deps

Conversation

@yostyle
Copy link
Copy Markdown
Contributor

@yostyle yostyle commented Oct 3, 2023 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Remove React-native-webrtc dependency. WebRTC library coming with jitsi-meet-sdk 8.1.1

Motivation and context

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested review from a team and bmarty and removed request for a team October 3, 2023 15:31
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ElementBot
Copy link
Copy Markdown

ElementBot commented Oct 3, 2023

Warnings
⚠️

vector/build.gradle#L204 - A newer version of androidx.browser:browser than 1.5.0 is available: 1.6.0
⚠️

vector/build.gradle#L204 - A newer version of androidx.browser:browser than 1.5.0 is available: 1.6.0
⚠️

vector/build.gradle#L204 - A newer version of androidx.browser:browser than 1.5.0 is available: 1.6.0
⚠️

vector/build.gradle#L204 - A newer version of androidx.browser:browser than 1.5.0 is available: 1.6.0
⚠️

vector/build.gradle#L244 - A newer version of androidx.emoji2:emoji2 than 1.3.0 is available: 1.4.0
⚠️

vector/build.gradle#L244 - A newer version of androidx.emoji2:emoji2 than 1.3.0 is available: 1.4.0
⚠️

vector/build.gradle#L244 - A newer version of androidx.emoji2:emoji2 than 1.3.0 is available: 1.4.0
⚠️

vector/build.gradle#L244 - A newer version of androidx.emoji2:emoji2 than 1.3.0 is available: 1.4.0

Generated by 🚫 dangerJS against b422f52

@yostyle yostyle enabled auto-merge (squash) October 4, 2023 15:05
bmarty
bmarty reviewed Oct 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine if 1-1 call and Jitsi calls are tested OK. Can you confirm please?

@yostyle
Copy link
Copy Markdown
Contributor Author

yostyle commented Oct 19, 2023

It's fine if 1-1 call and Jitsi calls are tested OK. Can you confirm please?

Yes we tested 1-1 and Jitsi calls

@yostyle yostyle requested a review from bmarty October 23, 2023 15:55
@yostyle
Copy link
Copy Markdown
Contributor Author

yostyle commented Oct 23, 2023

Signed-off-by: yostyle y.pintas@gmail.com

bmarty
bmarty approved these changes Nov 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks!

@yostyle yostyle merged commit b14338d into develop Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmarty bmarty bmarty approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yostyle @ElementBot @bmarty