Skip to content

Ensure the incoming call will not ring forever, in case the call is not ended by another way#8660

Merged
bmarty merged 1 commit into
developfrom
feature/bma/stopInfiniteRingingCall
Oct 6, 2023
Merged

Ensure the incoming call will not ring forever, in case the call is not ended by another way#8660
bmarty merged 1 commit into
developfrom
feature/bma/stopInfiniteRingingCall

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented Oct 6, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Ensure the incoming call will not ring forever, in case the call is not ended by another way.
Add a safe 2 minutes timer.

Motivation and context

Fixes #8178

Screenshots / GIFs

Tests

  • Receive a call, the phone rings
  • move to airplane mode
  • without the patch: the phone rings forever
  • with the patch: the phone stop ringing after 2 minutes

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

…ot ended by another way (#8178)

Add a safe 2 minutes timer.
@bmarty bmarty requested a review from ganfra October 6, 2023 08:46
Copy link
Copy Markdown
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM not tested

@bmarty bmarty merged commit ebc81e2 into develop Oct 6, 2023
@bmarty bmarty deleted the feature/bma/stopInfiniteRingingCall branch October 6, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All devices keep ringing except on the device that answered the call, never stop ringing until manually told to

2 participants