Ensure Background sync is not stopped when there is an active call.#8674
Merged
Conversation
jonnyandrew
approved these changes
Nov 7, 2023
It was happening since the application is foregrounded when VectorCallActivity is displayed.
…ven when the app goes to background.
57d5d62 to
8d85d04
Compare
|
SonarCloud Quality Gate failed.
|
Contributor
|
Hi, @bmarty. There's no release issue for 1.6.8, so I'm pinging you here. Could you please let the F-Droid team know so that F-Droid users can get this version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.











Type of change
Content
Ensure Background sync is not stopped when there is an active call.
It was happening since the application is foregrounded when VectorCallActivity is displayed.
Motivation and context
Closes #4066
Screenshots / GIFs
Tests
Then either the caller cancel the call, or answer the call from another session.
Previously the call was ringing forever. With this change, the device stops ringing, and the background sync is correctly cancelled. The device does not need to sync forever once the call is over.
Also did some smoke test around call, since this code is quite complex and not covered by unit tests.
Tested devices
Checklist