Fix setup secure backup#8786
Merged
Merged
Conversation
…e had to wait for the next sync response.
ganfra
approved these changes
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Content
This PR contains 2 fixes:
To reproduce, on this screen ^ click on "Reset Keys" and observe that as soon as the loading dialog is dimissed, the keys are updated on screen. Previously user had to wait at most 30s to see the update.
BootstrapReAuthFragmentis displayed, a first submit request is performed. Else an infinite loading wheel was displayed.To reproduce the issue:
With this PR, the infinite loading wheel is not displayed, and if necessary, the
ReAuthActivityis launch, to either ask the user to enter their password or login again using SSOI have tested OK the direct flow (i.e. without entering the password) and the flow with entering the password. To test this flow you have to wait for the grace period server side to expire (not sure what the grace period duration is on matrix.org).
Motivation and context
Fix infinite loading wheel.
Screenshots / GIFs
Tests
Tested devices
Checklist