Skip to content

chore: refactor IdentityCache to make resource more opaque#8736

Merged
runspired merged 9 commits intomainfrom
refactor-identity-utils
Jul 27, 2023
Merged

chore: refactor IdentityCache to make resource more opaque#8736
runspired merged 9 commits intomainfrom
refactor-identity-utils

Conversation

@runspired
Copy link
Contributor

similar to #8725 but with an approach more likely to be perf happy

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality ci-perf Activates Performance Checks in CI labels Jul 26, 2023
@github-actions
Copy link

github-actions bot commented Jul 26, 2023

Performance Report for 6127e14

Scenario - basic-record-materialization: ✅ Performance improved

✅ duration
phase estimated improvement -43ms [-67ms to -13ms] OR -1.63% [-2.57% to -0.51%]
⚠️ Phase [navigationStart] => [start-data-generation]
phase estimated regression +4ms [3ms to 5ms] OR +3.86% [2.55% to 5.02%]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [0ms to 3ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -36ms [-49ms to -22ms] OR -2.52% [-3.45% to -1.53%]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [end-record-materialization]
phase no difference [-16ms to 11ms]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [-7ms to 4ms]

Scenario - relationship-materialization-simple: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +14ms [7ms to 20ms] OR +1.61% [0.87% to 2.39%]
⚠️ Phase [navigationStart] => [start-find-all]
phase estimated regression +6ms [5ms to 7ms] OR +5.57% [4.44% to 6.75%]
⚠️ Phase [start-find-all] => [start-materialization]
phase estimated regression +16ms [13ms to 20ms] OR +4.74% [3.7% to 5.74%]
✅ Phase [start-materialization] => [end-materialization]
phase estimated improvement -12ms [-16ms to -8ms] OR -3.27% [-4.48% to -2.06%]
⚠️ Phase [end-materialization] => [Test End]
phase estimated regression +1ms [1ms to 3ms] OR +4.28% [2.05% to 10.92%]

Scenario - relationship-materialization-complex: ☑️ Performance is stable

☑️ duration
phase no difference [-41ms to 1ms]
⚠️ Phase [navigationStart] => [start-data-generation]
phase estimated regression +5ms [4ms to 7ms] OR +5.27% [3.95% to 6.49%]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [0ms to 1ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-9ms to 3ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-3ms to 3ms]
☑️ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase no difference [-31ms to 3ms]
✅ Phase [end-relationship-materialization] => [Test End]
phase estimated improvement -4ms [-9ms to 0ms] OR -2.05% [-4.09% to -0.2%]

Scenario - unload: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +18ms [13ms to 24ms] OR +2.07% [1.46% to 2.72%]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +4ms [3ms to 6ms] OR +1.97% [1.34% to 2.71%]
⚠️ Phase [start-push-payload] => [start-unload-records]
phase estimated regression +11ms [6ms to 15ms] OR +2.28% [1.34% to 3.16%]
⚠️ Phase [start-unload-records] => [end-unload-records]
phase estimated regression +3ms [1ms to 5ms] OR +2.07% [0.68% to 3.57%]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unload-all: ✅ Performance improved

✅ duration
phase estimated improvement -40ms [-52ms to -29ms] OR -2.08% [-2.7% to -1.52%]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +5ms [3ms to 6ms] OR +1.43% [0.99% to 1.85%]
✅ Phase [start-push-payload] => [start-materialization]
phase estimated improvement -36ms [-42ms to -28ms] OR -3.87% [-4.58% to -3.06%]
✅ Phase [start-materialization] => [start-unload-all]
phase estimated improvement -3ms [-7ms to 0ms] OR -1.27% [-2.44% to -0.1%]
✅ Phase [start-unload-all] => [end-unload-all]
phase estimated improvement -6ms [-10ms to -2ms] OR -1.72% [-2.85% to -0.58%]
✅ Phase [end-unload-all] => [Test End]
phase estimated improvement -1ms [-2ms to -1ms] OR -4% [-5.05% to -3.04%]

Scenario - destroy: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +9ms [4ms to 14ms] OR +1.04% [0.48% to 1.62%]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +5ms [4ms to 6ms] OR +2.37% [1.73% to 3.07%]
⚠️ Phase [start-push-payload] => [start-destroy-records]
phase estimated regression +7ms [3ms to 11ms] OR +1.49% [0.66% to 2.23%]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-4ms to 1ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ✅ Performance improved

✅ duration
phase estimated improvement -7ms [-11ms to -3ms] OR -1.17% [-1.8% to -0.54%]
⚠️ Phase [navigationStart] => [start-push-initial-payload]
phase estimated regression +6ms [4ms to 9ms] OR +2.76% [1.68% to 3.84%]
✅ Phase [start-push-initial-payload] => [start-push-update-payload]
phase estimated improvement -7ms [-9ms to -4ms] OR -3.47% [-4.81% to -2.18%]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-4ms to 1ms]
✅ Phase [end-push-update-payload] => [Test End]
phase estimated improvement -6ms [-6ms to -6ms] OR -16.95% [-17.45% to -16.37%]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-2ms to 9ms]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +5ms [4ms to 7ms] OR +2.59% [1.74% to 3.42%]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-4ms to 5ms]
✅ Phase [end-push-payload] => [Test End]
phase estimated improvement -1ms [-3ms to -1ms] OR -3.46% [-11.31% to -2.04%]

@runspired runspired merged commit cb3dbaa into main Jul 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the refactor-identity-utils branch July 27, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-perf Activates Performance Checks in CI 🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant