Fix check for new records in JSONAPISerializer.serializeHasMany#8794
Merged
runspired merged 1 commit intowarp-drive-data:mainfrom Aug 26, 2023
Merged
Fix check for new records in JSONAPISerializer.serializeHasMany#8794runspired merged 1 commit intowarp-drive-data:mainfrom
runspired merged 1 commit intowarp-drive-data:mainfrom
Conversation
Use `!Snapshot.isNew` instead of `Snapshot.record && !Snapshot.record.isNew` to avoid the access to `record`. Accessing `record` creates an entry in `instanceCache.record` which causes the `hasRecord` checks in `Snapshot` to return true. This results in an error when serializing associated records via hasMany that have not been loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
!Snapshot.isNewinstead ofSnapshot.record && !Snapshot.record.isNewto avoid the access torecord. Accessingrecordcreates an entry ininstanceCache.recordwhich causes thehasRecordchecks inSnapshotto return true. This results in an error when serializing associated records via hasMany that have not been loaded.fixes #8793