Mark new exception blocks nocover (they weren't really covered before either)

Author: akx

httpcore/_backends/anyio.py

@@ -28,13 +28,13 @@ async def read(self, max_bytes: int, timeout: float | None = None) -> bytes:
                     return await self._stream.receive(max_bytes=max_bytes)
                 except anyio.EndOfStream:  # pragma: nocover
                     return b""
-        except TimeoutError as exc:
+        except TimeoutError as exc:  # pragma: nocover
             raise ReadTimeout(exc) from exc
         except (
             anyio.BrokenResourceError,
             anyio.ClosedResourceError,
             anyio.EndOfStream,
-        ) as exc:
+        ) as exc:  # pragma: nocover
             raise ReadError(exc) from exc
 
     async def write(self, buffer: bytes, timeout: float | None = None) -> None:
@@ -44,9 +44,12 @@ async def write(self, buffer: bytes, timeout: float | None = None) -> None:
         try:
             with anyio.fail_after(timeout):
                 await self._stream.send(item=buffer)
-        except TimeoutError as exc:
+        except TimeoutError as exc:  # pragma: nocover
             raise WriteTimeout(exc) from exc
-        except (anyio.BrokenResourceError, anyio.ClosedResourceError) as exc:
+        except (
+            anyio.BrokenResourceError,
+            anyio.ClosedResourceError,
+        ) as exc:  # pragma: nocover
             raise WriteError(exc) from exc
 
     async def aclose(self) -> None:
@@ -71,9 +74,13 @@ async def start_tls(
             except Exception as exc:  # pragma: nocover
                 await self.aclose()
                 raise exc
-        except TimeoutError as exc:
+        except TimeoutError as exc:  # pragma: nocover
             raise ConnectTimeout(exc) from exc
-        except (anyio.BrokenResourceError, anyio.EndOfStream, ssl.SSLError) as exc:
+        except (
+            anyio.BrokenResourceError,
+            anyio.EndOfStream,
+            ssl.SSLError,
+        ) as exc:  # pragma: nocover
             raise ConnectError(exc) from exc
         return AnyIOStream(ssl_stream)
 

httpcore/_backends/sync.py

@@ -129,9 +129,9 @@ def read(self, max_bytes: int, timeout: float | None = None) -> bytes:
         try:
             self._sock.settimeout(timeout)
             return self._sock.recv(max_bytes)
-        except socket.timeout as exc:
+        except socket.timeout as exc:  # pragma: nocover
             raise ReadTimeout(exc) from exc
-        except OSError as exc:
+        except OSError as exc:  # pragma: nocover
             raise ReadError(exc) from exc
 
     def write(self, buffer: bytes, timeout: float | None = None) -> None:
@@ -143,9 +143,9 @@ def write(self, buffer: bytes, timeout: float | None = None) -> None:
                 self._sock.settimeout(timeout)
                 n = self._sock.send(buffer)
                 buffer = buffer[n:]
-        except socket.timeout as exc:
+        except socket.timeout as exc:  # pragma: nocover
             raise WriteTimeout(exc) from exc
-        except OSError as exc:
+        except OSError as exc:  # pragma: nocover
             raise WriteError(exc) from exc
 
     def close(self) -> None:
@@ -174,9 +174,9 @@ def start_tls(
             except Exception as exc:  # pragma: nocover
                 self.close()
                 raise exc
-        except socket.timeout as exc:
+        except socket.timeout as exc:  # pragma: nocover
             raise ConnectTimeout(exc) from exc
-        except OSError as exc:
+        except OSError as exc:  # pragma: nocover
             raise ConnectError(exc) from exc
         return SyncStream(sock)
 
@@ -219,9 +219,9 @@ def connect_tcp(
             for option in socket_options:
                 sock.setsockopt(*option)  # pragma: no cover
             sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
-        except socket.timeout as exc:
+        except socket.timeout as exc:  # pragma: nocover
             raise ConnectTimeout(exc) from exc
-        except OSError as exc:
+        except OSError as exc:  # pragma: nocover
             raise ConnectError(exc) from exc
         return SyncStream(sock)
 

httpcore/_backends/trio.py

@@ -26,9 +26,12 @@ async def read(self, max_bytes: int, timeout: float | None = None) -> bytes:
             with trio.fail_after(timeout_or_inf):
                 data: bytes = await self._stream.receive_some(max_bytes=max_bytes)
                 return data
-        except trio.TooSlowError as exc:
+        except trio.TooSlowError as exc:  # pragma: nocover
             raise ReadTimeout(exc) from exc
-        except (trio.BrokenResourceError, trio.ClosedResourceError) as exc:
+        except (
+            trio.BrokenResourceError,
+            trio.ClosedResourceError,
+        ) as exc:  # pragma: nocover
             raise ReadError(exc) from exc
 
     async def write(self, buffer: bytes, timeout: float | None = None) -> None:
@@ -39,9 +42,12 @@ async def write(self, buffer: bytes, timeout: float | None = None) -> None:
         try:
             with trio.fail_after(timeout_or_inf):
                 await self._stream.send_all(data=buffer)
-        except trio.TooSlowError as exc:
+        except trio.TooSlowError as exc:  # pragma: nocover
             raise WriteTimeout(exc) from exc
-        except (trio.BrokenResourceError, trio.ClosedResourceError) as exc:
+        except (
+            trio.BrokenResourceError,
+            trio.ClosedResourceError,
+        ) as exc:  # pragma: nocover
             raise WriteError(exc) from exc
 
     async def aclose(self) -> None:
@@ -68,9 +74,9 @@ async def start_tls(
             except Exception as exc:  # pragma: nocover
                 await self.aclose()
                 raise exc
-        except trio.TooSlowError as exc:
+        except trio.TooSlowError as exc:  # pragma: nocover
             raise ConnectTimeout(exc) from exc
-        except trio.BrokenResourceError as exc:
+        except trio.BrokenResourceError as exc:  # pragma: nocover
             raise ConnectError(exc) from exc
         return TrioStream(ssl_stream)
 
@@ -123,9 +129,9 @@ async def connect_tcp(
                 )
                 for option in socket_options:
                     stream.setsockopt(*option)  # type: ignore[attr-defined] # pragma: no cover
-        except trio.TooSlowError as exc:
+        except trio.TooSlowError as exc:  # pragma: nocover
             raise ConnectTimeout(exc) from exc
-        except (trio.BrokenResourceError, OSError) as exc:
+        except (trio.BrokenResourceError, OSError) as exc:  # pragma: nocover
             raise ConnectError(exc) from exc
         return TrioStream(stream)