Setting app=... or transport=... should bypass environment proxies.#1122
Merged
lovelydinosaur merged 2 commits intomasterfrom Aug 2, 2020
Merged
Conversation
j178
approved these changes
Aug 2, 2020
Merged
|
Sorry to pop this back up, and this probably just reflects may lack of understanding of proxies, but I was wondering why using a transport also disregards the proxy. Looking at the requests HTTPAdapter (which seems to be similar in most regards), environmental proxies are maintained, so in the following example: The proxy is used in all but case 2. I ran into this when we migrated an app to an environment needing proxies, and found everything worked based on environment proxy settings except the one case in which we added retries when making a large number of calls to a somewhat flaky external service. It was straightforward to add proxy rules directly, so no complaints per se, but I was wondering on the rationale behind this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If either
app=...ortransport=...are passed explicitly, then no env-var proxies should be used.Closes #1039
Eg.