Some cleanup of cross library test imports (#177029)

There is a lot of cross-library importing in the framework unit tests
that I'd like to clean up, see the design doc for more:
https://docs.google.com/document/d/1UHxALQqCbmgjnM1RNV9xE2pK3IGyx-UktGX1D7hYCjs/edit?tab=t.0

This PR cleans up a few obvious instances and adds TODOs for others. I
created this while doing an investigation for the design doc linked
above. I hope that we'll be able to follow up with fixes for all of the
problematic tests (tracked in the issue below).

Part of flutter/flutter#177028

Author: justinmc

dev/bots/check_tests_cross_imports.dart

@@ -111,96 +111,67 @@ class TestsCrossImportChecker {
     'packages/flutter/test/widgets/text_test.dart',
     'packages/flutter/test/widgets/reorderable_list_test.dart',
     'packages/flutter/test/widgets/semantics_tester_generate_test_semantics_expression_for_current_semantics_tree_test.dart',
-    'packages/flutter/test/widgets/async_lifecycle_test.dart',
     'packages/flutter/test/widgets/slivers_appbar_floating_pinned_test.dart',
     'packages/flutter/test/widgets/scrollable_restoration_test.dart',
     'packages/flutter/test/widgets/text_golden_test.dart',
-    'packages/flutter/test/widgets/multi_view_parent_data_test.dart',
-    'packages/flutter/test/widgets/view_test.dart',
     'packages/flutter/test/widgets/two_dimensional_viewport_test.dart',
     'packages/flutter/test/widgets/list_view_viewporting_test.dart',
     'packages/flutter/test/widgets/table_test.dart',
     'packages/flutter/test/widgets/shortcuts_test.dart',
     'packages/flutter/test/widgets/ticker_provider_test.dart',
-    'packages/flutter/test/widgets/slotted_render_object_widget_test.dart',
-    'packages/flutter/test/widgets/semantics_2_test.dart',
     'packages/flutter/test/widgets/semantics_clipping_test.dart',
-    'packages/flutter/test/widgets/reparent_state_test.dart',
-    'packages/flutter/test/widgets/transitions_test.dart',
     'packages/flutter/test/widgets/restoration_scopes_moving_test.dart',
     'packages/flutter/test/widgets/linked_scroll_view_test.dart',
     'packages/flutter/test/widgets/sliver_floating_header_test.dart',
     'packages/flutter/test/widgets/page_transitions_test.dart',
-    'packages/flutter/test/widgets/parent_data_test.dart',
     'packages/flutter/test/widgets/editable_text_scribble_test.dart',
     'packages/flutter/test/widgets/draggable_scrollable_sheet_test.dart',
     'packages/flutter/test/widgets/autofill_group_test.dart',
     'packages/flutter/test/widgets/box_decoration_test.dart',
     'packages/flutter/test/widgets/range_maintaining_scroll_physics_test.dart',
     'packages/flutter/test/widgets/scroll_position_test.dart',
     'packages/flutter/test/widgets/sliver_tree_test.dart',
-    'packages/flutter/test/widgets/binding_live_test.dart',
     'packages/flutter/test/widgets/interactive_viewer_test.dart',
-    'packages/flutter/test/widgets/list_view_fling_test.dart',
     'packages/flutter/test/widgets/selectable_region_test.dart',
-    'packages/flutter/test/widgets/selectable_text_test.dart',
     'packages/flutter/test/widgets/editable_text_scribe_test.dart',
-    'packages/flutter/test/widgets/semantics_7_test.dart',
     'packages/flutter/test/widgets/scrollable_test.dart',
     'packages/flutter/test/widgets/semantics_debugger_test.dart',
     'packages/flutter/test/widgets/semantics_test.dart',
     'packages/flutter/test/widgets/page_route_builder_test.dart',
-    'packages/flutter/test/widgets/opacity_repaint_test.dart',
     'packages/flutter/test/widgets/two_dimensional_scroll_view_test.dart',
     'packages/flutter/test/widgets/routes_test.dart',
     'packages/flutter/test/widgets/listener_test.dart',
     'packages/flutter/test/widgets/text_selection_test.dart',
-    'packages/flutter/test/widgets/list_view_relayout_test.dart',
-    'packages/flutter/test/widgets/semantics_4_test.dart',
-    'packages/flutter/test/widgets/multi_view_binding_test.dart',
     'packages/flutter/test/widgets/app_test.dart',
     'packages/flutter/test/widgets/widget_inspector_test.dart',
     'packages/flutter/test/widgets/radio_group_test.dart',
     'packages/flutter/test/widgets/list_view_test.dart',
-    'packages/flutter/test/widgets/binding_deferred_first_frame_test.dart',
     'packages/flutter/test/widgets/sliver_resizing_header_test.dart',
     'packages/flutter/test/widgets/navigator_replacement_test.dart',
-    'packages/flutter/test/widgets/scroll_delegate_test.dart',
     'packages/flutter/test/widgets/implicit_animations_test.dart',
-    'packages/flutter/test/widgets/list_view_correction_test.dart',
     'packages/flutter/test/widgets/default_text_editing_shortcuts_test.dart',
     'packages/flutter/test/widgets/page_storage_test.dart',
     'packages/flutter/test/widgets/sliver_main_axis_group_test.dart',
-    'packages/flutter/test/widgets/semantics_zero_surface_size_test.dart',
     'packages/flutter/test/widgets/color_filter_test.dart',
     'packages/flutter/test/widgets/semantics_merge_test.dart',
-    'packages/flutter/test/widgets/semantics_9_test.dart',
     'packages/flutter/test/widgets/modal_barrier_test.dart',
     'packages/flutter/test/widgets/sliver_semantics_test.dart',
     'packages/flutter/test/widgets/slivers_padding_test.dart',
     'packages/flutter/test/widgets/sliver_constraints_test.dart',
     'packages/flutter/test/widgets/autocomplete_test.dart',
-    'packages/flutter/test/widgets/icon_data_test.dart',
     'packages/flutter/test/widgets/expansible_test.dart',
     'packages/flutter/test/widgets/decorated_sliver_test.dart',
     'packages/flutter/test/widgets/shape_decoration_test.dart',
-    'packages/flutter/test/widgets/semantics_refactor_regression_test.dart',
     'packages/flutter/test/widgets/run_app_test.dart',
-    'packages/flutter/test/widgets/animated_opacity_repaint_test.dart',
-    'packages/flutter/test/widgets/semantics_6_test.dart',
     'packages/flutter/test/widgets/shadow_test.dart',
     'packages/flutter/test/widgets/routes_transition_test.dart',
     'packages/flutter/test/widgets/placeholder_test.dart',
-    'packages/flutter/test/widgets/animated_image_filtered_repaint_test.dart',
     'packages/flutter/test/widgets/route_notification_messages_test.dart',
     'packages/flutter/test/widgets/animated_cross_fade_test.dart',
     'packages/flutter/test/widgets/editable_text_shortcuts_test.dart',
     'packages/flutter/test/widgets/gesture_detector_test.dart',
-    'packages/flutter/test/widgets/tree_shape_test.dart',
-    'packages/flutter/test/widgets/rich_text_test.dart',
     'packages/flutter/test/widgets/router_test.dart',
     'packages/flutter/test/widgets/scroll_notification_test.dart',
-    'packages/flutter/test/widgets/sensitive_content_error_handling_test.dart',
     'packages/flutter/test/widgets/magnifier_test.dart',
     'packages/flutter/test/widgets/backdrop_filter_test.dart',
     'packages/flutter/test/widgets/editable_text_test.dart',
@@ -209,11 +180,6 @@ class TestsCrossImportChecker {
     'packages/flutter/test/widgets/scrollable_helpers_test.dart',
     'packages/flutter/test/widgets/slivers_appbar_stretch_test.dart',
     'packages/flutter/test/widgets/sliver_cross_axis_group_test.dart',
-    'packages/flutter/test/widgets/drag_boundary_test.dart',
-    'packages/flutter/test/widgets/semantics_traversal_test.dart',
-    'packages/flutter/test/widgets/sensitive_content_unknown_test.dart',
-    'packages/flutter/test/widgets/overlay_test.dart',
-    'packages/flutter/test/widgets/semantics_8_test.dart',
     'packages/flutter/test/widgets/list_wheel_scroll_view_test.dart',
     'packages/flutter/test/widgets/scrollable_dispose_test.dart',
     'packages/flutter/test/widgets/pop_scope_test.dart',
@@ -223,33 +189,23 @@ class TestsCrossImportChecker {
     'packages/flutter/test/widgets/obscured_animated_image_test.dart',
     'packages/flutter/test/widgets/platform_menu_bar_test.dart',
     'packages/flutter/test/widgets/inherited_test.dart',
-    'packages/flutter/test/widgets/sliver_fill_viewport_test.dart',
-    'packages/flutter/test/widgets/wrap_test.dart',
     'packages/flutter/test/widgets/heroes_test.dart',
-    'packages/flutter/test/widgets/overlay_portal_test.dart',
     'packages/flutter/test/widgets/slivers_evil_test.dart',
-    'packages/flutter/test/widgets/semantics_11_test.dart',
     'packages/flutter/test/widgets/container_test.dart',
     'packages/flutter/test/widgets/drawer_test.dart',
     'packages/flutter/test/widgets/framework_test.dart',
     'packages/flutter/test/widgets/ticker_mode_test.dart',
     'packages/flutter/test/widgets/absorb_pointer_test.dart',
     'packages/flutter/test/widgets/semantics_role_checks_test.dart',
-    'packages/flutter/test/widgets/binding_first_frame_rasterized_test.dart',
     'packages/flutter/test/widgets/media_query_test.dart',
     'packages/flutter/test/widgets/editable_text_cursor_test.dart',
     'packages/flutter/test/widgets/sliver_fill_remaining_test.dart',
-    'packages/flutter/test/widgets/router_restoration_test.dart',
     'packages/flutter/test/widgets/semantics_keep_alive_offstage_test.dart',
     'packages/flutter/test/widgets/editable_text_show_on_screen_test.dart',
     'packages/flutter/test/widgets/system_context_menu_test.dart',
-    'packages/flutter/test/widgets/error_widget_test.dart',
-    'packages/flutter/test/widgets/semantics_checks_test.dart',
     'packages/flutter/test/widgets/scrollable_fling_test.dart',
     'packages/flutter/test/widgets/debug_test.dart',
     'packages/flutter/test/widgets/banner_test.dart',
-    'packages/flutter/test/widgets/sensitive_content_test.dart',
-    'packages/flutter/test/widgets/semantics_10_test.dart',
     'packages/flutter/test/widgets/sliver_persistent_header_test.dart',
     'packages/flutter/test/widgets/transformed_scrollable_test.dart',
     'packages/flutter/test/widgets/run_app_async_test.dart',
@@ -263,42 +219,30 @@ class TestsCrossImportChecker {
     'packages/flutter/test/widgets/spell_check_test.dart',
     'packages/flutter/test/widgets/slivers_appbar_floating_test.dart',
     'packages/flutter/test/widgets/toggleable_test.dart',
-    'packages/flutter/test/widgets/semantics_1_test.dart',
-    'packages/flutter/test/widgets/sensitive_content_host_test.dart',
     'packages/flutter/test/widgets/mouse_region_test.dart',
     'packages/flutter/test/widgets/draggable_test.dart',
     'packages/flutter/test/widgets/page_transitions_builder_test.dart',
     'packages/flutter/test/widgets/selectable_region_context_menu_test.dart',
-    'packages/flutter/test/widgets/default_colors_test.dart',
-    'packages/flutter/test/widgets/multi_view_tree_updates_test.dart',
     'packages/flutter/test/widgets/sliversemantics_test.dart',
     'packages/flutter/test/widgets/scroll_activity_test.dart',
     'packages/flutter/test/widgets/tap_region_test.dart',
     'packages/flutter/test/widgets/lookup_boundary_test.dart',
     'packages/flutter/test/widgets/reassemble_test.dart',
-    'packages/flutter/test/widgets/semantics_5_test.dart',
-    'packages/flutter/test/widgets/clip_test.dart',
-    'packages/flutter/test/widgets/independent_widget_layout_test.dart',
-    'packages/flutter/test/widgets/binding_first_frame_developer_test.dart',
     'packages/flutter/test/widgets/html_element_view_test.dart',
     'packages/flutter/test/widgets/navigator_test.dart',
-    'packages/flutter/test/widgets/multi_view_no_implicit_view_binding_test.dart',
     'packages/flutter/test/widgets/text_semantics_test.dart',
     'packages/flutter/test/widgets/safe_area_test.dart',
     'packages/flutter/test/widgets/page_view_test.dart',
     'packages/flutter/test/widgets/undo_history_test.dart',
     'packages/flutter/test/widgets/scroll_view_test.dart',
     'packages/flutter/test/widgets/focus_traversal_test.dart',
     'packages/flutter/test/widgets/sliver_list_test.dart',
-    'packages/flutter/test/widgets/reparent_state_with_layout_builder_test.dart',
     'packages/flutter/test/widgets/page_forward_transitions_test.dart',
     'packages/flutter/test/widgets/context_menu_controller_test.dart',
-    'packages/flutter/test/widgets/semantics_3_test.dart',
     'packages/flutter/test/widgets/slivers_test.dart',
     'packages/flutter/test/widgets/navigator_restoration_test.dart',
     'packages/flutter/test/widgets/sliver_prototype_item_extent_test.dart',
     'packages/flutter/test/widgets/simple_semantics_test.dart',
-    'packages/flutter/test/widgets/sliver_appbar_opacity_test.dart',
     'packages/flutter/test/widgets/image_filter_test.dart',
     'packages/flutter/test/widgets/navigator_on_did_remove_page_test.dart',
     'packages/flutter/test/widgets/opacity_test.dart',
@@ -307,15 +251,11 @@ class TestsCrossImportChecker {
     'packages/flutter/test/widgets/scrollable_semantics_test.dart',
     'packages/flutter/test/widgets/sliver_visibility_test.dart',
     'packages/flutter/test/widgets/rotated_box_test.dart',
-    'packages/flutter/test/widgets/sliver_constrained_cross_axis_test.dart',
     'packages/flutter/test/widgets/single_child_scroll_view_test.dart',
     'packages/flutter/test/widgets/pinned_header_sliver_test.dart',
-    'packages/flutter/test/widgets/focus_manager_test.dart',
     'packages/flutter/test/widgets/raw_radio_test.dart',
     'packages/flutter/test/widgets/syncing_test.dart',
     'packages/flutter/test/widgets/form_test.dart',
-    'packages/flutter/test/widgets/implicit_semantics_test.dart',
-    'packages/flutter/test/widgets/shrink_wrapping_viewport_test.dart',
   };
 
   /// These Cupertino tests are known to have cross imports. These cross imports
@@ -341,7 +281,6 @@ class TestsCrossImportChecker {
     'packages/flutter/test/cupertino/magnifier_test.dart',
     'packages/flutter/test/cupertino/text_field_restoration_test.dart',
     'packages/flutter/test/cupertino/sheet_test.dart',
-    'packages/flutter/test/cupertino/action_sheet_test.dart',
     'packages/flutter/test/cupertino/form_row_test.dart',
     'packages/flutter/test/cupertino/colors_test.dart',
     'packages/flutter/test/cupertino/text_form_field_row_restoration_test.dart',

packages/flutter/test/cupertino/action_sheet_test.dart

@@ -11,7 +11,6 @@ import 'dart:ui';
 
 import 'package:flutter/cupertino.dart';
 import 'package:flutter/foundation.dart';
-import 'package:flutter/material.dart';
 import 'package:flutter/rendering.dart';
 import 'package:flutter/services.dart';
 
@@ -1845,9 +1844,8 @@ void main() {
       await tester.tap(find.text('Go'));
       await tester.pump();
 
-      // The inherited ScrollBehavior should not apply Scrollbars since they are
+      // The inherited ScrollBehavior should not apply scrollbars since they are
       // already built in to the widget.
-      expect(find.byType(Scrollbar), findsNothing);
       expect(find.byType(RawScrollbar), findsNothing);
       // Built in CupertinoScrollbars should only number 2: one for the actions,
       // one for the content.
@@ -2450,7 +2448,7 @@ void main() {
 
     tester.binding.focusManager.highlightStrategy = FocusHighlightStrategy.alwaysTraditional;
 
-    const Color focusColor = Colors.orange;
+    const focusColor = Color(0xffffaaaa);
 
     final Color defaultDarkFocusColor = HSLColor.fromColor(
       focusColor.withOpacity(kCupertinoButtonTintedOpacityDark),

packages/flutter/test/cupertino/app_test.dart

@@ -579,6 +579,8 @@ void main() {
     debugBrightnessOverride = null;
   });
 
+  // TODO(justinmc): Cupertino tests should not import Material.
+  // https://github.com/flutter/flutter/issues/177028
   testWidgets('CupertinoApp creates a Material theme with colors based off of Cupertino theme', (
     WidgetTester tester,
   ) async {

packages/flutter/test/cupertino/colors_test.dart

@@ -532,6 +532,8 @@ void main() {
     expect(color.value, dynamicColor.darkHighContrastElevatedColor.value);
   });
 
+  // TODO(justinmc): Don't test Material interactions in Cupertino tests.
+  // https://github.com/flutter/flutter/issues/177028
   group('MaterialApp:', () {
     Color? color;
     setUp(() {

packages/flutter/test/cupertino/date_picker_test.dart

@@ -2140,6 +2140,8 @@ void main() {
     handle.dispose();
   });
 
+  // TODO(justinmc): Don't test Material interactions in Cupertino tests.
+  // https://github.com/flutter/flutter/issues/177028
   testWidgets('DatePicker adapts to MaterialApp dark mode', (WidgetTester tester) async {
     Widget buildDatePicker(Brightness brightness) {
       return MaterialApp(
@@ -2167,6 +2169,8 @@ void main() {
     expect(paragraph.text.style!.color.toString().contains('UNRESOLVED'), isFalse);
   });
 
+  // TODO(justinmc): Don't test Material interactions in Cupertino tests.
+  // https://github.com/flutter/flutter/issues/177028
   testWidgets('TimerPicker adapts to MaterialApp dark mode', (WidgetTester tester) async {
     Widget buildTimerPicker(Brightness brightness) {
       return MaterialApp(

packages/flutter/test/cupertino/dialog_test.dart

@@ -1846,9 +1846,8 @@ void main() {
       await tester.tap(find.text('Go'));
       await tester.pump();
 
-      // The inherited ScrollBehavior should not apply Scrollbars since they are
+      // The inherited ScrollBehavior should not apply scrollbars since they are
       // already built in to the widget.
-      expect(find.byType(Scrollbar), findsNothing);
       expect(find.byType(RawScrollbar), findsNothing);
       // Built in CupertinoScrollbars should only number 2: one for the actions,
       // one for the content.

packages/flutter/test/cupertino/form_row_test.dart

@@ -148,6 +148,8 @@ void main() {
     expect(errorTextStyle.style.color, CupertinoColors.destructiveRed);
   });
 
+  // TODO(justinmc): Don't test Material interactions in Cupertino tests.
+  // https://github.com/flutter/flutter/issues/177028
   testWidgets('CupertinoFormRow adapts to MaterialApp dark mode', (WidgetTester tester) async {
     const Widget prefix = Text('Prefix');
     const Widget helper = Text('Helper');

packages/flutter/test/cupertino/picker_test.dart

@@ -697,6 +697,8 @@ void main() {
     );
   });
 
+  // TODO(justinmc): Don't test Material interactions in Cupertino tests.
+  // https://github.com/flutter/flutter/issues/177028
   testWidgets('Picker adapts to MaterialApp dark mode', (WidgetTester tester) async {
     Widget buildCupertinoPicker(Brightness brightness) {
       return MaterialApp(

packages/flutter/test/cupertino/text_selection_test.dart

@@ -555,7 +555,6 @@ void main() {
             localizationsDelegates: const <LocalizationsDelegate<dynamic>>[
               _LongCupertinoLocalizations.delegate,
               DefaultWidgetsLocalizations.delegate,
-              DefaultMaterialLocalizations.delegate,
             ],
             home: Directionality(
               textDirection: TextDirection.ltr,