Support limiting stats number per scope#42168
Merged
Merged
Conversation
Contributor
Author
TAOXUY
changed the title
kyessenov
reviewed
Nov 21, 2025
Contributor
|
Assigning @kyessenov for a first-pass review. |
Contributor
Author
|
/retest |
Member
|
@TAOXUY needs main merge @kyessenov i think this is awaiting further review |
Contributor
|
Sorry for the delay. Jason is on my team, and we chat offline about it. |
kyessenov
reviewed
Jan 8, 2026
Contributor
kyessenov
left a comment
kyessenov
left a comment
There was a problem hiding this comment.
Main comment is that I'm not sure we can get away with per-scope limit - you can have multiple scopes per listener, and we need some way to impose a global limit since this is ultimately a global constraint. Otherwise, implementation is fine, but we need public doc for the new overflow stat.
Contributor
Author
|
/retest |
kyessenov
requested changes
Jan 15, 2026
Contributor
|
/wait |
Contributor
Author
Have to force push after rebasing. @kyessenov you can see the last commit for the diff. |
Contributor
Author
|
/retest |
kyessenov
reviewed
Jan 21, 2026
Contributor
Author
|
/retest |
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Contributor
Author
|
/retest |
kyessenov
previously approved these changes
Jan 22, 2026
Signed-off-by: Xuyang Tao <taoxuy@google.com>
kyessenov
approved these changes
Jan 22, 2026
Contributor
Author
|
/retest |
shane-yuan
pushed a commit
to shane-yuan/envoy
that referenced
this pull request
Feb 11, 2026
Commit Message: add support for limiting the max number of stats(counter/gauge/histogram) per scope. This helps with memory explosion caused by high cardinality stats. Risk Level: low Testing: unit test covered Docs Changes: no doc update as it is a library support for internal usage Release Notes: updated Platform Specific Features: no --------- Signed-off-by: Xuyang Tao <taoxuy@google.com>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
Commit Message: add support for limiting the max number of stats(counter/gauge/histogram) per scope. This helps with memory explosion caused by high cardinality stats. Risk Level: low Testing: unit test covered Docs Changes: no doc update as it is a library support for internal usage Release Notes: updated Platform Specific Features: no --------- Signed-off-by: Xuyang Tao <taoxuy@google.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
wbpcode
pushed a commit
to wbpcode/envoy
that referenced
this pull request
Mar 23, 2026
Commit Message: add support for limiting the max number of stats(counter/gauge/histogram) per scope. This helps with memory explosion caused by high cardinality stats. Risk Level: low Testing: unit test covered Docs Changes: no doc update as it is a library support for internal usage Release Notes: updated Platform Specific Features: no --------- Signed-off-by: Xuyang Tao <taoxuy@google.com>
wbpcode
pushed a commit
to wbpcode/envoy
that referenced
this pull request
Mar 27, 2026
Commit Message: add support for limiting the max number of stats(counter/gauge/histogram) per scope. This helps with memory explosion caused by high cardinality stats. Risk Level: low Testing: unit test covered Docs Changes: no doc update as it is a library support for internal usage Release Notes: updated Platform Specific Features: no --------- Signed-off-by: Xuyang Tao <taoxuy@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: add support for limiting the max number of stats(counter/gauge/histogram) per scope. This helps with memory explosion caused by high cardinality stats.
Risk Level: low
Testing: unit test covered
Docs Changes: no doc update as it is a library support for internal usage
Release Notes: updated
Platform Specific Features: no