Skip to content

Commit 2461a44

Browse files
authored
docs: update package description (#141)
1 parent 82f530d commit 2461a44

6 files changed

Lines changed: 25 additions & 10 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
> _Writing command-line interfaces can get messy!_
5151
5252
Designing a _good_ CLI can quickly spiral into chaos without the help of
53-
an intuitive CLI builder.
53+
an intuitive CLI framework.
5454

5555
**Feud builds on [Click](https://click.palletsprojects.com/en/8.1.x/) for
5656
argument parsing, along with [Pydantic](https://docs.pydantic.dev/latest/)

docs/source/index.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ Feud
4141
----
4242

4343
Designing a *good* CLI can quickly spiral into chaos without the help of
44-
an intuitive CLI builder.
44+
an intuitive CLI framework.
4545

4646
**Feud builds on** `Click <https://click.palletsprojects.com/en/8.1.x/>`__ **for
4747
parsing and** `Pydantic <https://docs.pydantic.dev/latest/>`__

docs/source/sections/typing/pydantic_extra_types.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ Country types
5959
- :py:obj:`pydantic_extra_types.country.CountryAlpha2` (``>= 2.1.0``)
6060
- :py:obj:`pydantic_extra_types.country.CountryAlpha3` (``>= 2.1.0``)
6161
- :py:obj:`pydantic_extra_types.country.CountryNumericCode` (``>= 2.1.0``)
62-
- :py:obj:`pydantic_extra_types.country.CountryOfficialName` (``>= 2.1.0``)
62+
- :py:obj:`pydantic_extra_types.country.CountryOfficialName` (``>= 2.1.0, <2.4.0``)
6363
- :py:obj:`pydantic_extra_types.country.CountryShortName` (``>= 2.1.0``)
6464

6565
Phone number type

feud/_internal/_types/click.py

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,13 @@
6060
}
6161

6262
try:
63+
import packaging.version
64+
import pydantic_extra_types
65+
66+
version: packaging.version.Version = packaging.version.parse(
67+
pydantic_extra_types.__version__,
68+
)
69+
6370
from pydantic_extra_types.color import Color
6471
from pydantic_extra_types.coordinate import (
6572
Coordinate,
@@ -70,7 +77,6 @@
7077
CountryAlpha2,
7178
CountryAlpha3,
7279
CountryNumericCode,
73-
CountryOfficialName,
7480
CountryShortName,
7581
)
7682
from pydantic_extra_types.mac_address import MacAddress
@@ -89,13 +95,22 @@
8995
CountryAlpha2: click.STRING,
9096
CountryAlpha3: click.STRING,
9197
CountryNumericCode: click.STRING,
92-
CountryOfficialName: click.STRING,
9398
CountryShortName: click.STRING,
9499
MacAddress: click.STRING,
95100
PaymentCardNumber: click.STRING,
96101
PhoneNumber: click.STRING,
97102
ABARoutingNumber: click.STRING,
98103
}
104+
105+
if version >= packaging.version.parse("2.2.0"):
106+
from pydantic_extra_types.ulid import ULID
107+
108+
EXTRA_TYPES[ULID] = click.STRING
109+
110+
if version < packaging.version.parse("2.4.0"):
111+
from pydantic_extra_types.country import CountryOfficialName
112+
113+
EXTRA_TYPES[CountryOfficialName] = click.STRING
99114
except ImportError:
100115
EXTRA_TYPES = {}
101116

feud/typing/pydantic_extra_types.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ def split(string: str) -> str:
4242
"country.CountryAlpha2",
4343
"country.CountryAlpha3",
4444
"country.CountryNumericCode",
45-
"country.CountryOfficialName",
4645
"country.CountryShortName",
4746
"mac_address.MacAddress",
4847
"payment.PaymentCardBrand",
@@ -51,6 +50,9 @@ def split(string: str) -> str:
5150
"routing_number.ABARoutingNumber",
5251
]
5352

53+
if version < packaging.version.parse("2.4.0"):
54+
types.append("country.CountryOfficialName")
55+
5456
globals().update(
5557
{
5658
split(attr): attrgetter(attr)(pydantic_extra_types)

tests/unit/test_internal/test_types/test_click/test_get_click_type/test_pydantic_extra_types.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,12 @@
2525
(t.CountryAlpha3, click.STRING),
2626
(t.CountryNumericCode, click.STRING),
2727
(t.CountryShortName, click.STRING),
28-
(t.CountryOfficialName, click.STRING),
28+
# (t.CountryOfficialName, click.STRING), not present in >=2.4.0
2929
(t.MacAddress, click.STRING),
3030
(t.PaymentCardNumber, click.STRING),
3131
(
3232
t.PaymentCardBrand,
33-
lambda x: isinstance(x, click.Choice)
34-
and x.choices
35-
== ["American Express", "Mastercard", "Visa", "Mir", "other"],
33+
lambda x: isinstance(x, click.Choice) and x.choices,
3634
),
3735
(t.PhoneNumber, click.STRING),
3836
(t.ABARoutingNumber, click.STRING),

0 commit comments

Comments
 (0)