chore(test-client-clis): final fusaka mapper fixes (#1859)

* chore(test-client-clis): final fusaka mapper fixes

* chore(test-tests): fix `gas_price` in `test_tx_gas_limit` to isolate gas limit validation

* chore(test-client-clis): re-add `NONCE_MISMATCH_TOO_LOW` mapping back for nethermind

* chore(test-client-clis): re-add `NONCE_MISMATCH_TOO_LOW` mapping back for ethrex

Author: spencer-tb

packages/testing/src/execution_testing/client_clis/clis/besu.py

@@ -322,6 +322,9 @@ class BesuExceptionMapper(ExceptionMapper):
         TransactionException.NONCE_MISMATCH_TOO_LOW: (
             r"transaction invalid transaction nonce \d+ below sender account nonce \d+"
         ),
+        TransactionException.NONCE_MISMATCH_TOO_HIGH: (
+            r"transaction invalid transaction nonce \d+ does not match sender account nonce \d+"
+        ),
         TransactionException.GAS_LIMIT_EXCEEDS_MAXIMUM: (
             r"transaction invalid Transaction gas limit must be at most \d+"
         ),

packages/testing/src/execution_testing/client_clis/clis/erigon.py

@@ -23,6 +23,7 @@ class ErigonExceptionMapper(ExceptionMapper):
         TransactionException.PRIORITY_GREATER_THAN_MAX_FEE_PER_GAS: "tip higher than fee cap",
         TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS: "max fee per blob gas too low",
         TransactionException.NONCE_MISMATCH_TOO_LOW: "nonce too low",
+        TransactionException.NONCE_MISMATCH_TOO_HIGH: "nonce too high",
         TransactionException.GAS_ALLOWANCE_EXCEEDED: "gas limit reached",
         TransactionException.TYPE_3_TX_PRE_FORK: "blob txn is not supported by signer",
         TransactionException.TYPE_3_TX_INVALID_BLOB_VERSIONED_HASH: (

packages/testing/src/execution_testing/client_clis/clis/ethrex.py

@@ -39,8 +39,8 @@ class EthrexExceptionMapper(ExceptionMapper):
             r"reject transactions from senders with deployed code|"
             r"Sender account .* shouldn't be a contract"
         ),
-        TransactionException.NONCE_MISMATCH_TOO_LOW: r"nonce \d+ too low, expected \d+|"
-        r"Nonce mismatch.*",
+        TransactionException.NONCE_MISMATCH_TOO_LOW: r"nonce \d+ too low, expected \d+|Nonce mismatch.*",
+        TransactionException.NONCE_MISMATCH_TOO_HIGH: r"Nonce mismatch.*",
         TransactionException.TYPE_3_TX_MAX_BLOB_GAS_ALLOWANCE_EXCEEDED: (
             r"blob gas used \d+ exceeds maximum allowance \d+"
         ),

packages/testing/src/execution_testing/client_clis/clis/nethermind.py

@@ -392,6 +392,7 @@ class NethermindExceptionMapper(ExceptionMapper):
         TransactionException.NONCE_IS_MAX: "NonceTooHigh",
         TransactionException.INITCODE_SIZE_EXCEEDED: "max initcode size exceeded",
         TransactionException.NONCE_MISMATCH_TOO_LOW: "wrong transaction nonce",
+        TransactionException.NONCE_MISMATCH_TOO_HIGH: "wrong transaction nonce",
         TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS: (
             "InsufficientMaxFeePerBlobGas: Not enough to cover blob gas fee"
         ),

packages/testing/src/execution_testing/client_clis/clis/reth.py

@@ -30,9 +30,6 @@ class RethExceptionMapper(ExceptionMapper):
         TransactionException.TYPE_4_TX_PRE_FORK: (
             "eip 7702 transactions present in pre-prague payload"
         ),
-        BlockException.INVALID_DEPOSIT_EVENT_LAYOUT: (
-            "failed to decode deposit requests from receipts"
-        ),
         BlockException.INVALID_REQUESTS: "mismatched block requests hash",
         BlockException.INVALID_RECEIPTS_ROOT: "receipt root mismatch",
         BlockException.INVALID_STATE_ROOT: "mismatched block state root",
@@ -45,6 +42,7 @@ class RethExceptionMapper(ExceptionMapper):
     }
     mapping_regex = {
         TransactionException.NONCE_MISMATCH_TOO_LOW: r"nonce \d+ too low, expected \d+",
+        TransactionException.NONCE_MISMATCH_TOO_HIGH: r"nonce \d+ too high, expected \d+",
         TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS: (
             r"blob gas price \(\d+\) is greater than max fee per blob gas \(\d+\)"
         ),
@@ -100,11 +98,21 @@ class RethExceptionMapper(ExceptionMapper):
         BlockException.INCORRECT_BLOCK_FORMAT: (
             r"Block's access list is invalid."
         ),
-        BlockException.INVALID_GASLIMIT: (r"child gas_limit \d+ max .* is .*"),
-        BlockException.INVALID_BLOCK_TIMESTAMP_OLDER_THAN_PARENT: (
-            r"block timestamp \d+ is in the past compared to the parent timestamp \d+"
-        ),
-        BlockException.INVALID_BLOCK_NUMBER: (
-            r"block number \d+ does not match parent block number \d+"
+        # Reth does not validate the sizes or offsets of the deposit
+        # contract logs. As a workaround we have set
+        # INVALID_DEPOSIT_EVENT_LAYOUT equal to INVALID_REQUESTS.
+        #
+        # Although this is out of spec, it is understood that this
+        # will not cause an issue so long as the mainnet/testnet
+        # deposit contracts don't change.
+        #
+        # The offsets are checked second and the sizes are checked
+        # third within the `is_valid_deposit_event_data` function:
+        # https://eips.ethereum.org/EIPS/eip-6110#block-validity
+        #
+        # EELS definition for `is_valid_deposit_event_data`:
+        # https://github.com/ethereum/execution-specs/blob/5ddb904fa7ba27daeff423e78466744c51e8cb6a/src/ethereum/forks/prague/requests.py#L51
+        BlockException.INVALID_DEPOSIT_EVENT_LAYOUT: (
+            r"failed to decode deposit requests from receipts|mismatched block requests hash"
         ),
     }

tests/frontier/validation/test_transaction.py

@@ -30,7 +30,7 @@ def test_tx_gas_limit(
     tx = Transaction(
         gas_limit=21001,
         to=to,
-        gas_price=0x01,
+        gas_price=0x10,  # Must be >= base fee to isolate gas limit validation
         sender=sender,
         protected=False,
         error=TransactionException.GAS_ALLOWANCE_EXCEEDED,