Skip to content

Commit 173fea5

Browse files
tac0turtletac0turtle
andauthored
fix: reduce resources consumption in ci (#2462)
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview This pr reduces the amount of nodes we run and increases the timeout in order to try to make ci more consistent closes #2425 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Reduced the number of nodes involved in a transaction gossiping test for improved efficiency. * Adjusted synchronization and shutdown timing to better match the new test configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: tac0turtle <you@example.com>
1 parent f57fbb9 commit 173fea5

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

node/full_node_integration_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ import (
1414
)
1515

1616
// TestTxGossipingMultipleNodesNoDA tests that transactions are gossiped and blocks are sequenced and synced across multiple nodes without the DA layer over P2P.
17-
// It creates 4 nodes (1 sequencer, 3 full nodes), injects a transaction, waits for all nodes to sync, and asserts block equality.
17+
// It creates 3 nodes (1 sequencer, 2 full nodes), injects a transaction, waits for all nodes to sync, and asserts block equality.
1818
func TestTxGossipingMultipleNodesNoDA(t *testing.T) {
1919
require := require.New(t)
2020
config := getTestConfig(t, 1)
2121
// Set the DA block time to a very large value to ensure that the DA layer is not used
2222
config.DA.BlockTime = rollkitconfig.DurationWrapper{Duration: 100 * time.Second}
23-
numNodes := 4
23+
numNodes := 3
2424
nodes, cleanups := createNodesWithCleanup(t, numNodes, config)
2525
for _, cleanup := range cleanups {
2626
defer cleanup()
@@ -48,14 +48,14 @@ func TestTxGossipingMultipleNodesNoDA(t *testing.T) {
4848
executor := nodes[0].blockManager.GetExecutor().(*coreexecutor.DummyExecutor)
4949
executor.InjectTx([]byte("test tx"))
5050

51-
blocksToWaitFor := uint64(5)
51+
blocksToWaitFor := uint64(3)
5252
// Wait for all nodes to reach at least blocksToWaitFor blocks
5353
for _, node := range nodes {
5454
require.NoError(waitForAtLeastNBlocks(node, blocksToWaitFor, Store))
5555
}
5656

5757
// Shutdown all nodes and wait
58-
shutdownAndWait(t, cancels, &runningWg, 5*time.Second)
58+
shutdownAndWait(t, cancels, &runningWg, 10*time.Second)
5959

6060
// Assert that all nodes have the same block up to height blocksToWaitFor
6161
assertAllNodesSynced(t, nodes, blocksToWaitFor)

0 commit comments

Comments
 (0)