fix(node): propagate context through LeaderResigner.ResignLeader interface

- LeaderResigner.ResignLeader() → ResignLeader(ctx context.Context) error
- FullNode.ResignLeader passes ctx down to raft.Node.ResignLeader
- run_node.go calls resigner.ResignLeader(resignCtx) directly — no wrapper
  goroutine/select needed; context.DeadlineExceeded vs other errors are
  logged distinctly
- Merge TestFullNode_ResignLeader_NilRaftNode and
  TestFullNode_ResignLeader_NonLeaderRaftNode into single table-driven test

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: auricom

node/full.go

@@ -392,9 +392,9 @@ func (n *FullNode) IsRunning() bool {
 
 // ResignLeader transfers raft leadership before the node shuts down.
 // It is a no-op when raft is not enabled or this node is not the leader.
-func (n *FullNode) ResignLeader() error {
+func (n *FullNode) ResignLeader(ctx context.Context) error {
 	if n.raftNode == nil {
 		return nil
 	}
-	return n.raftNode.ResignLeader()
+	return n.raftNode.ResignLeader(ctx)
 }

node/full_node_test.go

@@ -84,14 +84,18 @@ func TestStartInstrumentationServer(t *testing.T) {
 	}
 }
 
-func TestFullNode_ResignLeader_NilRaftNode(t *testing.T) {
-	n := &FullNode{} // raftNode is nil
-	assert.NoError(t, n.ResignLeader())
-}
-
-func TestFullNode_ResignLeader_NonLeaderRaftNode(t *testing.T) {
-	// Empty *raftpkg.Node has nil raft field so IsLeader() returns false;
-	// ResignLeader() is a no-op and returns nil.
-	n := &FullNode{raftNode: &raftpkg.Node{}}
-	assert.NoError(t, n.ResignLeader())
+func TestFullNode_ResignLeader_Noop(t *testing.T) {
+	cases := []struct {
+		name string
+		node *FullNode
+	}{
+		{name: "nil raftNode", node: &FullNode{}},
+		// Empty *raftpkg.Node has nil raft field so IsLeader() returns false.
+		{name: "non-leader raftNode", node: &FullNode{raftNode: &raftpkg.Node{}}},
+	}
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			assert.NoError(t, tc.node.ResignLeader(context.Background()))
+		})
+	}
 }

node/node.go

@@ -1,6 +1,8 @@
 package node
 
 import (
+	"context"
+
 	ds "github.com/ipfs/go-datastore"
 	"github.com/rs/zerolog"
 
@@ -25,7 +27,7 @@ type Node interface {
 // in Raft leader election. Callers should type-assert to this interface and call
 // ResignLeader before cancelling the node context on graceful shutdown.
 type LeaderResigner interface {
-	ResignLeader() error
+	ResignLeader(ctx context.Context) error
 }
 
 type NodeOptions struct {

pkg/cmd/run_node.go

@@ -230,17 +230,14 @@ func StartNode(
 		if resigner, ok := rollnode.(node.LeaderResigner); ok {
 			resignCtx, resignCancel := context.WithTimeout(context.Background(), 3*time.Second)
 			defer resignCancel()
-			resignDone := make(chan error, 1)
-			go func() { resignDone <- resigner.ResignLeader() }()
-			select {
-			case err := <-resignDone:
-				if err != nil {
-					logger.Warn().Err(err).Msg("leadership resign on shutdown failed")
+			if err := resigner.ResignLeader(resignCtx); err != nil {
+				if errors.Is(err, context.DeadlineExceeded) {
+					logger.Warn().Msg("leadership resign timed out")
 				} else {
-					logger.Info().Msg("leadership resigned before shutdown")
+					logger.Warn().Err(err).Msg("leadership resign on shutdown failed")
 				}
-			case <-resignCtx.Done():
-				logger.Warn().Msg("leadership resign timed out")
+			} else {
+				logger.Info().Msg("leadership resigned before shutdown")
 			}
 		}
 		cancel()