fix: Fix Validation logic (#2237)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

NOTE: PR titles should follow semantic commits:
https://www.conventionalcommits.org/en/v1.0.0/
-->

## Overview
Closes: #2230 

Uses approach 2 

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 

Ex: Closes #<issue number>
-->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added robust batch transaction submission to the Data Availability
(DA) layer with retry, backoff, and gas price adjustment.
- Introduced DA inclusion tracking that advances only when both header
and data are confirmed on the DA layer.
- Improved block and data validation with explicit DA commitment checks.
  - Enhanced cache management with new methods for hash-based access.

- **Bug Fixes**
- Improved error handling and robustness in deserialization and DA
inclusion logic.
- Fixed configuration and terminology inconsistencies, shifting from
"blocks" to "headers" in pending limits and related settings.

- **Documentation**
- Updated specifications to clarify DA inclusion requirements and
document new DAIncluderLoop and SetFinal message.
  - Added and improved comments for tests and configuration options.

- **Tests**
- Expanded and refined test coverage for DA inclusion, batch submission,
retriever logic, and synchronization.
- Improved test reliability with parallel execution and better state
management.

- **Chores**
- Updated dependencies and configuration defaults for improved
maintainability.
- Refactored and cleaned up internal code and test setup for clarity and
efficiency.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: tac0turtle <you@example.com>
Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: julienrbrt <julien@rbrt.fr>

Author: 4 people

.golangci.yml

@@ -34,7 +34,6 @@ linters:
       - examples$
 formatters:
   enable:
-    - gci
     - gofmt
   settings:
     gci:

block/aggregation_test.go

@@ -20,8 +20,9 @@ import (
 	"github.com/rollkit/rollkit/types"
 )
 
-// TestAggregationLoop_Normal_BasicInterval verifies the basic time interval logic of the normal aggregation loop.
+// TestAggregationLoop_Normal_BasicInterval verifies that the aggregation loop publishes blocks at the expected interval under normal conditions.
 func TestAggregationLoop_Normal_BasicInterval(t *testing.T) {
+	t.Parallel()
 	assert := assert.New(t)
 	require := require.New(t)
 
@@ -114,8 +115,9 @@ func TestAggregationLoop_Normal_BasicInterval(t *testing.T) {
 	}
 }
 
-// TestAggregationLoop_Normal_PublishBlockError verifies the loop continues after publishBlock returns an error.
+// TestAggregationLoop_Normal_PublishBlockError verifies that the aggregation loop handles errors from publishBlock gracefully.
 func TestAggregationLoop_Normal_PublishBlockError(t *testing.T) {
+	t.Parallel()
 	assert := assert.New(t)
 	require := require.New(t)
 

block/daIncluder.go

@@ -0,0 +1,65 @@
+package block
+
+import (
+	"context"
+	"encoding/binary"
+	"fmt"
+)
+
+// DAIncluderLoop is responsible for advancing the DAIncludedHeight by checking if blocks after the current height
+// have both their header and data marked as DA-included in the caches. If so, it calls setDAIncludedHeight.
+func (m *Manager) DAIncluderLoop(ctx context.Context) {
+	for {
+		select {
+		case <-ctx.Done():
+			return
+		case <-m.daIncluderCh:
+			// proceed to check for DA inclusion
+		}
+		currentDAIncluded := m.GetDAIncludedHeight()
+		for {
+			nextHeight := currentDAIncluded + 1
+			daIncluded, err := m.IsDAIncluded(ctx, nextHeight)
+			if err != nil {
+				// No more blocks to check at this time
+				m.logger.Debug("no more blocks to check at this time", "height", nextHeight, "error", err)
+				break
+			}
+			if daIncluded {
+				// Both header and data are DA-included, so we can advance the height
+				if err := m.incrementDAIncludedHeight(ctx); err != nil {
+					panic(fmt.Errorf("error while incrementing DA included height: %w", err))
+				}
+				currentDAIncluded = nextHeight
+			} else {
+				// Stop at the first block that is not DA-included
+				break
+			}
+		}
+	}
+}
+
+// incrementDAIncludedHeight sets the DA included height in the store
+// It returns an error if the DA included height is not set.
+func (m *Manager) incrementDAIncludedHeight(ctx context.Context) error {
+	currentHeight := m.GetDAIncludedHeight()
+	newHeight := currentHeight + 1
+	m.logger.Debug("setting final", "height", newHeight)
+	err := m.exec.SetFinal(ctx, newHeight)
+	if err != nil {
+		m.logger.Error("failed to set final", "height", newHeight, "error", err)
+		return err
+	}
+	heightBytes := make([]byte, 8)
+	binary.LittleEndian.PutUint64(heightBytes, newHeight)
+	m.logger.Debug("setting DA included height", "height", newHeight)
+	err = m.store.SetMetadata(ctx, DAIncludedHeightKey, heightBytes)
+	if err != nil {
+		m.logger.Error("failed to set DA included height", "height", newHeight, "error", err)
+		return err
+	}
+	if !m.daIncludedHeight.CompareAndSwap(currentHeight, newHeight) {
+		return fmt.Errorf("failed to set DA included height: %d", newHeight)
+	}
+	return nil
+}