feedback

Author: tac0turtle

apps/grpc/single/go.sum

@@ -22,8 +22,6 @@ github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
 github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
 github.com/bradfitz/go-smtpd v0.0.0-20170404230938-deb6d6237625/go.mod h1:HYsPBTaaSFSlLx/70C2HPIMNZpVV8+vt/A+FMnYP11g=
 github.com/buger/jsonparser v0.0.0-20181115193947-bf1c66bbce23/go.mod h1:bbYlZJ7hK1yFx9hf58LP0zeX7UjIGs20ufpu3evjr+s=
-github.com/celestiaorg/go-header v0.7.3 h1:3+kIa+YXT789gPGRh3a55qmdYq3yTTBIqTyum26AvN0=
-github.com/celestiaorg/go-header v0.7.3/go.mod h1:eX9iTSPthVEAlEDLux40ZT/olXPGhpxHd+mEzJeDhd0=
 github.com/celestiaorg/go-libp2p-messenger v0.2.2 h1:osoUfqjss7vWTIZrrDSy953RjQz+ps/vBFE7bychLEc=
 github.com/celestiaorg/go-libp2p-messenger v0.2.2/go.mod h1:oTCRV5TfdO7V/k6nkx7QjQzGrWuJbupv+0o1cgnY2i4=
 github.com/celestiaorg/go-square/v3 v3.0.2 h1:eSQOgNII8inK9IhiBZ+6GADQeWbRq4HYY72BOgcduA4=
@@ -176,6 +174,8 @@ github.com/json-iterator/go v1.1.6/go.mod h1:+SdeFBvtyEkXs7REEP0seUULqWtbJapLOCV
 github.com/jstemmer/go-junit-report v0.0.0-20190106144839-af01ea7f8024/go.mod h1:6v2b51hI/fHJwM22ozAgKL4VKDeJcHhJFhtBdhmNjmU=
 github.com/jtolds/gls v4.20.0+incompatible h1:xdiiI2gbIgH/gLH7ADydsJ1uDOEzR8yvV7C0MuV77Wo=
 github.com/jtolds/gls v4.20.0+incompatible/go.mod h1:QJZ7F/aHp+rZTRtaJ1ow/lLfFfVYBRgL+9YlvaHOwJU=
+github.com/julienrbrt/go-header v0.0.0-20251008134330-747c8c192fa8 h1:F+gOiipBxG43s+Ho+ri9T8IwumjWjp1XUon4DLWjxfQ=
+github.com/julienrbrt/go-header v0.0.0-20251008134330-747c8c192fa8/go.mod h1:eX9iTSPthVEAlEDLux40ZT/olXPGhpxHd+mEzJeDhd0=
 github.com/kisielk/errcheck v1.5.0/go.mod h1:pFxgyoBC7bSaBwPgfKdkLd5X25qrDl4LWUI2bnpBCr8=
 github.com/kisielk/gotool v1.0.0/go.mod h1:XhKaO+MFFWcvkIS/tQcRk01m1F5IRFswLeQ+oQHNcck=
 github.com/klauspost/compress v1.18.0 h1:c/Cqfb0r+Yi+JtIEq73FWXVkRonBlf0CRNYc8Zttxdo=

block/internal/syncing/syncer.go

@@ -268,18 +268,11 @@ func (s *Syncer) processLoop() {
 
 func (s *Syncer) startSyncWorkers() {
 	s.wg.Add(2)
-	go s.daWorker()
-	go s.pendingWorker()
+	go s.daWorkerLoop()
+	go s.pendingWorkerLoop()
 }
 
 func (s *Syncer) startP2PListeners() error {
-	if s.headerStore == nil {
-		return errors.New("header store not configured")
-	}
-	if s.dataStore == nil {
-		return errors.New("data store not configured")
-	}
-
 	headerNotifier := s.headerStore.Notifier()
 	if headerNotifier == nil {
 		return errors.New("header notifier not configured")
@@ -324,22 +317,15 @@ func (s *Syncer) consumeNotifierEvents(sub *syncnotifier.Subscription, expected
 				logger.Debug().Str("received_type", string(evt.Type)).Msg("ignoring notifier event with unexpected type")
 				continue
 			}
-			s.handleNotifierEvent(evt)
+			s.logger.Debug().Str("event_type", string(evt.Type)).Str("source", string(evt.Source)).Uint64("height", evt.Height).Msg("received store event")
+			s.tryFetchFromP2P()
 		}
 	}
 }
 
-func (s *Syncer) handleNotifierEvent(evt syncnotifier.Event) {
-	s.logger.Debug().Str("event_type", string(evt.Type)).Str("source", string(evt.Source)).Uint64("height", evt.Height).Msg("received store event")
-	s.tryFetchFromP2P()
-}
-
-func (s *Syncer) daWorker() {
+func (s *Syncer) daWorkerLoop() {
 	defer s.wg.Done()
-	s.daWorkerLoop()
-}
 
-func (s *Syncer) daWorkerLoop() {
 	if !s.waitForGenesis() {
 		return
 	}
@@ -363,12 +349,9 @@ func (s *Syncer) daWorkerLoop() {
 	}
 }
 
-func (s *Syncer) pendingWorker() {
+func (s *Syncer) pendingWorkerLoop() {
 	defer s.wg.Done()
-	s.pendingWorkerLoop()
-}
 
-func (s *Syncer) pendingWorkerLoop() {
 	if !s.waitForGenesis() {
 		return
 	}

codecov.yml

@@ -17,3 +17,4 @@ ignore:
   - "execution/evm" # EVM is covered in e2e/integration tests
   - "**/metrics.go"
   - "client" # TODO: add more tests
+  - "block/internal/**/*_mock.go"