Skip to content

Commit 2013bad

Browse files
sammy-SCrobhogan
authored andcommitted
Back out "RN: Enable useInsertionEffectsForAnimations" (#48669)
Summary: Pull Request resolved: #48669 Original commit changeset: d09b2f1b7607 Original Phabricator Diff: D65906157 [General] [Fixed] - Disable useInsertionEffectsForAnimations, Fix buttons becoming unresponsive when transform is animated Reviewed By: yungsters Differential Revision: D68152746 fbshipit-source-id: aa0c0aa3243c67c95128a75b40dd6aa1251abbca
1 parent 36a0cad commit 2013bad

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -546,11 +546,13 @@ const definitions: FeatureFlagDefinitions = {
546546
},
547547
},
548548
useInsertionEffectsForAnimations: {
549-
defaultValue: true,
549+
defaultValue: false,
550550
metadata: {
551+
dateAdded: '2024-09-12',
551552
description:
552553
'Changes construction of the animation graph to `useInsertionEffect` instead of `useLayoutEffect`.',
553-
purpose: 'release',
554+
expectedReleaseValue: true,
555+
purpose: 'experimentation',
554556
},
555557
},
556558
useRefsForTextInputState: {

packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7+
<<<<<<< HEAD
78
* @generated SignedSource<<83b5798ee1c7a28fffbf110e19641d69>>
9+
=======
10+
* @generated SignedSource<<3bdec862f75745ce81e9cf23fef82468>>
11+
>>>>>>> c799aa07e21 (Back out "RN: Enable `useInsertionEffectsForAnimations`" (#48669))
812
* @flow strict
913
*/
1014

@@ -170,7 +174,7 @@ export const shouldUseSetNativePropsInFabric: Getter<boolean> = createJavaScript
170174
/**
171175
* Changes construction of the animation graph to `useInsertionEffect` instead of `useLayoutEffect`.
172176
*/
173-
export const useInsertionEffectsForAnimations: Getter<boolean> = createJavaScriptFlagGetter('useInsertionEffectsForAnimations', true);
177+
export const useInsertionEffectsForAnimations: Getter<boolean> = createJavaScriptFlagGetter('useInsertionEffectsForAnimations', false);
174178

175179
/**
176180
* Enable a variant of TextInput that moves some state to refs to avoid unnecessary re-renders

0 commit comments

Comments
 (0)