Commit 9c64b4c
committed
[Fizz] Gracefully handle suspending in DOM configs (#26768)
E.g. if we suspend (throw a promise) in pushStartInstance today we might
have already pushed some chunks (or even child segments potentially). We
should revert back to where we were.
This doesn't usually happen because when we suspend in a component it
doesn't write anything itself, it'll always defer to som host instance
to do the writing.
There was a todo about this already but I'm not 100% sure it's always
safe when suspending. It should be safe when suspending just regularly
because it's just a noop. We might not even want "throwing a promise" in
this mechanism to be supported longer term but for now that's how a
suspend in internals.
DiffTrain build for commit c10010a.1 parent 1871a4c commit 9c64b4c
7 files changed
Lines changed: 9 additions & 9 deletions
File tree
- compiled-rn/facebook-fbsource/xplat/js
- RKJSModules/vendor
- react-test-renderer/cjs
- react/cjs
- react-native-github/Libraries/Renderer
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23918 | 23918 | | |
23919 | 23919 | | |
23920 | 23920 | | |
23921 | | - | |
| 23921 | + | |
23922 | 23922 | | |
23923 | 23923 | | |
23924 | 23924 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8623 | 8623 | | |
8624 | 8624 | | |
8625 | 8625 | | |
8626 | | - | |
| 8626 | + | |
8627 | 8627 | | |
8628 | 8628 | | |
8629 | 8629 | | |
| |||
8654 | 8654 | | |
8655 | 8655 | | |
8656 | 8656 | | |
8657 | | - | |
| 8657 | + | |
8658 | 8658 | | |
8659 | 8659 | | |
8660 | 8660 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9049 | 9049 | | |
9050 | 9050 | | |
9051 | 9051 | | |
9052 | | - | |
| 9052 | + | |
9053 | 9053 | | |
9054 | 9054 | | |
9055 | 9055 | | |
| |||
9080 | 9080 | | |
9081 | 9081 | | |
9082 | 9082 | | |
9083 | | - | |
| 9083 | + | |
9084 | 9084 | | |
9085 | 9085 | | |
9086 | 9086 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
642 | 642 | | |
643 | 643 | | |
644 | 644 | | |
645 | | - | |
| 645 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
645 | 645 | | |
646 | 646 | | |
647 | 647 | | |
648 | | - | |
| 648 | + | |
649 | 649 | | |
650 | 650 | | |
651 | 651 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments