Preserve error codes for invariants on www#12539
Merged
gaearon merged 2 commits intofacebook:masterfrom Apr 9, 2018
Merged
Conversation
gaearon
force-pushed
the
www-invariant-codes
branch
3 times, most recently
from
5e8ad95 to
fbfc1fe
Compare
Collaborator
Author
|
Confirmed this works internally combined with D7526921.
|
gaearon
force-pushed
the
www-invariant-codes
branch
2 times, most recently
from
ab388e7 to
0eb9531
Compare
gaearon
force-pushed
the
www-invariant-codes
branch
from
0eb9531 to
5ed64a6
Compare
bvaughn
approved these changes
Apr 9, 2018
Contributor
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
LGTM 👍
Quick smoke test and comparing builds looks okay.
This was referenced Apr 17, 2018
This was referenced Apr 19, 2018
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
* Preserve error codes for invariants on www * Remove unintentional change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we don't do any invariant transformation in www. It has its own pipeline which strips invariant messages completely. But that leaves us worse off because we don't have any codes at all.
With this change, prod www bundles will contain the error codes and a special
@preserve-invariant-messagesdirective that will prevent stripping their messages (since there’ll only be one in practice).The downside of this change is that with JS debugging parameter set to true but in PROD mode you'd have to click an extra time to see the error. Maybe that's not too bad if we fix the error dialog to linkify links.